Skip to content

Fix incorrect return value in getImageHeight method #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

Fix incorrect return value in getImageHeight method #3706

merged 1 commit into from
May 25, 2025

Conversation

xinhuagu
Copy link
Contributor

Description

a bug in the getImageHeight method of the AbstractImageFolder class where it was incorrectly returning the imageWidth value instead of imageHeight.

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xinhuagu xinhuagu requested review from zachgk and a team as code owners May 24, 2025 11:43
@xyang16 xyang16 merged commit 86d5c89 into deepjavalibrary:master May 25, 2025
5 checks passed
@xinhuagu xinhuagu deleted the fix/incorrect-getImageHeight branch May 25, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyang16 xyang16 xyang16 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

+1 more reviewer

@frankfliu frankfliu frankfliu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinhuagu @frankfliu @xyang16