Skip to content

Add NDArray diagonal #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Add NDArray diagonal #3724

merged 1 commit into from
Jun 30, 2025

Conversation

dev-jonghoonpark
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark commented Jun 29, 2025 •
edited
Loading

Description

Add NDArray diagonal

  • In the case of TensorFlow, DiagPart was used instead of Diag to produce results in the same format as PyTorch.
  • In the case of Apache MXNet, It is identified as a retired project, so it was handled with UnsupportedOperationException without additional searching.

close #2835.

@dev-jonghoonpark dev-jonghoonpark requested review from zachgk and a team as code owners June 29, 2025 05:07
frankfliu
frankfliu approved these changes Jun 29, 2025
View reviewed changes
Copy link
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@xyang16 xyang16 merged commit 3f3db59 into deepjavalibrary:master Jun 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyang16 xyang16 xyang16 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

+1 more reviewer

@frankfliu frankfliu frankfliu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NDArray diagonal
3 participants
@dev-jonghoonpark @frankfliu @xyang16