Skip to content

Fix buffer rewind compilation error compat with jdk 9+ #9245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

agibsonccc
Copy link
Contributor

See similar issue: apache/felix#114

What changes were proposed in this pull request?

Fixes java 9 compilation error related to bytebuffer types like mentioned above
(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

Quick checklist

The following checklist helps ensure your PR is complete:

  • [ X] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • [X ] Reviewed the Contributing Guidelines and followed the steps within.
  • [ X] Created tests for any significant new code additions.
  • [X ] Relevant tests for your changes are passing.

@agibsonccc agibsonccc merged commit a3e47c1 into master Apr 1, 2021
@agibsonccc agibsonccc deleted the ag_buffer_j9 branch April 1, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants