feat: Simpler generation spans, use Haystack's to_openai_dict_format #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:langfuse
type:documentation
|
@sjrl The only downside I see to this PR is aggressive requirement of haystack-ai > 2.15, forcing many to upgrade haystack-ai as well, wdyt? Maybe not a bad requirement but I wanted to hear your opinion. |
I think it's fine to have the high requirement. Users can always roll back to previous versions if they don't want to upgrade Haystack. |
sjrl
reviewed
Jul 3, 2025
sjrl
approved these changes
Jul 3, 2025
Co-authored-by: Sebastian Husch Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove temp patch introduced in #1885