Create validation rule for Hash Id #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I created this validation rule for my own purpose and I would like to contribute it to your package if it complies with your standards. I guess it's not the cleanest way to validate, but it works properly.
There is another commit I would like you to include (I guess even if you don't want this validation rule) that fixes an exception if you try to decode improper HashId.
This is a valid hash for my salt: XvKGYlLgyARBM. If I change any character (eg. XaKGYlLgyARBM)
keyFromHashIdwould thrown an Undefined array key exception.