pvm change#402
Draft
justsanjeev wants to merge 2 commits into
Draft
Conversation
justsanjeev
force-pushed
the
dlpx/pr/justsanjeev/0846dfd4-29bc-47f4-9cfc-d98951f0dbd3
branch
from
ba78bbb to
162b8f3
Compare
justsanjeev
force-pushed
the
dlpx/pr/justsanjeev/0846dfd4-29bc-47f4-9cfc-d98951f0dbd3
branch
from
f549350 to
0289159
Compare
Plain `git clone https://github.com/...` has no credentials and fails on this private repo. Use the same git init + git_fetch_helper + git checkout pattern fetch_repo_from_git already uses, which injects FETCH_GIT_TOKEN into the URL for github.com clones.
justsanjeev
force-pushed
the
dlpx/pr/justsanjeev/0846dfd4-29bc-47f4-9cfc-d98951f0dbd3
branch
from
0289159 to
a93adf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Provide a clear description of the high-level problem you are trying to
solve. The problem statement should be written in terms of a specific
symptom that affects users or the business. The problem statement should
not be written in terms of the solution. If possible, include a minimal
reproducible example (MRE) with steps to reproduce, expected results,
and actual results.
Solution
Provide a clear description of the high-level solution you have chosen.
If there were other possible solutions that you considered and rejected,
mention those along with the corresponding reasoning. Do not describe
implementation details when writing about the solution; these should go
into the implementation section instead.
Testing Done
Provide a clear description of how this change was tested. At minimum
this should include proof that a computer has executed the changed
lines. Ideally this should include an automated test or an explanation
as to why this pull request has no tests.