DLPX-92461 Add libkdumpfile10 and python3-drgn as dependencies of sdb to remove dependency on internal forks#344
Merged
palash-gandhi merged 1 commit intoOct 24, 2024
Conversation
… to remove dependency on internal forks PR URL: https://www.github.com/delphix/sdb/pull/344
palash-gandhi
force-pushed
the
dlpx/pr/palash-gandhi/9b88aacb-5cf3-4de4-ac21-60a4a8577039
branch
from
October 17, 2024 19:12
f7f53fb to
d696202
Compare
palash-gandhi
marked this pull request as ready for review
October 17, 2024 19:57
prakashsurya
approved these changes
Oct 17, 2024
prakashsurya
left a comment
Contributor
There was a problem hiding this comment.
seems reasonable.. I think we might want to use the latest drgn, as that's actively worked on and gets improvements.. but the folks that generally track that tooling/improvements aren't at delphix anymore, so this makes sense to me.. if we determine there's something we need that isn't in the ubuntu packages, we can do that later..
palash-gandhi
enabled auto-merge (squash)
October 23, 2024 21:52
sebroy
approved these changes
Oct 24, 2024
palash-gandhi
deleted the
dlpx/pr/palash-gandhi/9b88aacb-5cf3-4de4-ac21-60a4a8577039
branch
October 24, 2024 14:30
prakashsurya
pushed a commit
that referenced
this pull request
Mar 20, 2025
… to remove dependency on internal forks PR URL: #344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
libkdumpfile and drgn are currently built from internal sources. These 2 repos
have had minimal changes authored by Delphix and all of them are build-related or
related to the python2-3 migration. Maintaining internal forks causes overheads.
Solution
To reduce the dependency of using internal forks, this change adds these 2 packages
as dependencies of
sdbso that delphix/linux-pkg#325 can proceedTesting Done
https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/os-upgrade/job/build-package/job/sdb/job/pre-push/10/console
Some manual tests:
After installing python3-drgn and libkdumpfile
I think this is expected because the VM I used is a bootstrapped 24.04 VM without kernel debug symbols.