Skip to content

Adding credentials set support demisto rest api #17506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 24, 2022

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Feb 6, 2022

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

added credentials for the api-key key and relevant tests.

Does it break backward compatibility?

  • Yes
  • No

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are missing this #17506 (comment)

@ShahafBenYakir
Copy link
Contributor

@YuvHayun I already approved this 9 days ago. Fix the build errors and merge.

@ShahafBenYakir ShahafBenYakir removed their request for review February 22, 2022 21:52
@YuvHayun YuvHayun merged commit cdb445c into master Feb 24, 2022
@YuvHayun YuvHayun deleted the adding_credentials_set_support_demisto_rest_api branch February 24, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants