ScheduleGenericPolling #24945
Merged
ScheduleGenericPolling #24945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shellyber
reviewed
Feb 28, 2023
Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py
Outdated
Show resolved
Hide resolved
…ntent into ScheduleGenericPolling_to_py3
Shellyber
requested changes
Mar 1, 2023
Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py
Outdated
Show resolved
Hide resolved
Shellyber
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4174
Description
ScheduleGenericPolling to py3.
Removed encoding to utf-8 (python 3 str support non-engilsh char) according to this PR https://github.com/demisto/content/pull/10150/files#diff-6c4153c0ef71204475f20bae67d3f028ec9cf9e4507679e487c2464122252542
Added test playbook to yml file- Generic Polling Test, Generic Polling Test used GenericPolling as a sub playbook and GenericPolling call to ScheduleGenericPolling script.
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have