[pre-commit MyPy] Align the entire repo with MyPy #3 #29819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmuel44
reviewed
Sep 26, 2023
shmuel44
reviewed
Sep 26, 2023
Packs/AWS-GuardDuty/Integrations/AWSGuardDutyEventCollector/AWSGuardDutyEventCollector.py
Outdated
Show resolved
Hide resolved
shmuel44
reviewed
Sep 26, 2023
Packs/AWS-SecurityHub/Integrations/AWSSecurityHubEventCollector/AWSSecurityHubEventCollector.py
Outdated
Show resolved
Hide resolved
shmuel44
reviewed
Sep 26, 2023
dorschw
approved these changes
Sep 26, 2023
dorschw
approved these changes
Sep 27, 2023
|
Reason for force merge: |
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* [pre-commit MyPy] Align the entire repo with MyPy #3 * Fix the typing * Add RNs * Fix mypy errors * Add hint type * Fix Flake8 errorsmypy errors * Fix mypy error * Fix mypy error * Fix review comments * Fix more types * Fix more types
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* [pre-commit MyPy] Align the entire repo with MyPy #3 * Fix the typing * Add RNs * Fix mypy errors * Add hint type * Fix Flake8 errorsmypy errors * Fix mypy error * Fix mypy error * Fix review comments * Fix more types * Fix more types
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* [pre-commit MyPy] Align the entire repo with MyPy #3 * Fix the typing * Add RNs * Fix mypy errors * Add hint type * Fix Flake8 errorsmypy errors * Fix mypy error * Fix mypy error * Fix review comments * Fix more types * Fix more types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
Related: link to the issue
Description
In order to run
pre-commiton our entire repo, it is necessary to fix certain files that fail themypyhook.