PAN-OS - Security Advisories Vulnerability Check

[aneeshamore]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

New playbook to analyze Firewall software version and Global Protect client package version for vulnerability to a Palo Alto Networks Security Advisory

Must have

• Tests
• Documentation

[aneeshamore]

@michalgold FYI.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/PAN-OS/Scripts/CheckFirewallAndGPForCVEs
CheckFirewallAndGPForCVEs.py	83	19	77%	49, 97, 110–111, 114, 155, 164–169, 195–196, 211, 224, 268, 270–271
Packs/PAN-OS/Scripts/PANOSSecurityAdvisoriesEnrichment
PANOSSecurityAdvisoriesEnrichment.py	138	39	71%	26, 81–86, 88, 95–96, 98–108, 116–119, 121–123, 232–233, 235–240, 242–244
TOTAL	221	58	73%

Tests	Skipped	Failures	Errors	Time
21	0 💤	0 ❌	0 🔥	2.166s ⏱️

[merit-maita]

@aneeshamore it looks good, please handle the merge conflict and the failing pre-commit and validation steps.
@Benimanela please review the playbooks

[aneeshamore]

@merit-maita I have committed fixes based on the last pre-commit and validation errors. I am waiting for PR ##40583 to be merged. Then there shouldn't be any conflict. In the latest validation check, the script failed on Validation for validate_config file but it does not indicate any issues with my files. Could you please help me with that?

[merit-maita]

@merit-maita I have committed fixes based on the last pre-commit and validation errors. I am waiting for PR ##40583 to be merged. Then there shouldn't be any conflict. In the latest validation check, the script failed on Validation for validate_config file but it does not indicate any issues with my files. Could you please help me with that?

the PR ##40583 is already merged now,
regarding the issue with the validate, pulling from master is supposed to solve the issue

[aneeshamore]

@richardbluestone Please review docs.

[content-bot]

Validate summary
The following errors were thrown as a part of this pr: GR110.
The following errors cannot be ignored: GR110.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ❌

[m-berman]

Hi @aneeshamore
I made suggestions. After you have implemented the suggestions you like, could you please use the SDK to regenerate the markdown? Then I can take another look.
Thanks

[m-berman]

Approved docs.

[merit-maita]

the validation is failing due to the task id key being missing for task 7, i think it should looks something like what im suggesting here.
after making the change, please make sure the edited playbook is still working.

Suggested change

	timertriggers: []
	taskid: 9ce917fd-b79c-4508-908e-90095d0761dd
	timertriggers: []