Workday #7478
Merged
Workday #7478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovi
suggested changes
Jun 11, 2020
| @@ -0,0 +1 @@ | |||
| Workday offers enterprise-level software solutions for financial management, human resources, and planning. | |||
There was a problem hiding this comment.
update with credentials information, how to get tenant name and token
There was a problem hiding this comment.
waiting for @Arsenikr with this one
* Changed `Phone Number` field source. (and changed expected context accordingly) * Changed Test_module output * Changed username and password params to credentials type. in Workday.yml * Changed TPB according to Shai's review in Workday_-_Test.yml * Added TPB details to conf.json
Co-authored-by: Shai Yaakovi <[email protected]>
Co-authored-by: Shai Yaakovi <[email protected]>
yaakovi
approved these changes
Jun 18, 2020
|
@Bargenish Done. |
# Conflicts: # Tests/conf.json
Added Workday TPB to skipped tests (lack of access)
# Conflicts: # Tests/conf.json
Itay4
added a commit
that referenced
this pull request
Jun 24, 2020
* add test for get_msg_mail_format with headers set to none * catch all types of exceptions raised in get_msg_format * New RN summary (#7133) * in progress * in progress * in progress * in progress * in progress * in progress * in progress * in progress * changed RN file name * added comments * test in progress * updated script * updated script * updated script * test fix helloworld * in progress * in progress * in progress * in progress * in progress * in progress * in progress * added test * fix * fixed doc * in progress * updated new release notes generator * in progress * in progress * in progress * in progress * fixed ignored release notes validations and added tests * small fixes * restored .gitignore * added new packs to release notes generator * fixed unit tests * fixed lint error * fixed lint error * fixed modified packs collection * Fixed handling of ignored section in RN files * fixed modified release notes filter * start merging pack versions block to single block * added support for merging pack versions block to single block * added unit test for merge release notes block function * fixed small formatting issue * fixed CR notes * fixed content-descriptor.json path * fixed time formats in content-descriptor.json Co-authored-by: syaakovi <[email protected]> * Microsoft azure feed (#7715) * Microsoft azure feed (#7410) * Add pack Azure AD Connect Health Feed * Clean up * Passed all tests * Fix test playbook * Minor fixes * Minor changes * remove changelog * change integration name global * include integration name in demisto.info * add docstring to substitution function * add disclaimer to readme * remove the other changelog * add command_examples.txt and generate readme with demisto-sdk * remove entries in tests/conf.json * remove urls from readme as it fails secrets test * remove trailing space * add entries back to conf.json as it fails pre-commit otherwise * remove exept blocks and apply suggestion to subs function * add suggested changes * Fix issue with results dict * changes to avoid duplicated indicators * remove substitution function as it's not deded Co-authored-by: Bar Katzir <[email protected]> * chnge taskid task.id TO UUIDS Co-authored-by: Guillermo Serrano <[email protected]> Co-authored-by: Bar Katzir <[email protected]> Co-authored-by: bar katzir <[email protected]> * Workday (#7478) * creating workday pack * Worker context build function * Integration Ready but README.md, fine-tuning on unitests and TPB * Added Unittests and README.md * * Removed "Business_Title" from headers * Changed `Phone Number` field source. (and changed expected context accordingly) * Changed Test_module output * Changed username and password params to credentials type. in Workday.yml * Changed TPB according to Shai's review in Workday_-_Test.yml * Added TPB details to conf.json Co-authored-by: Shai Yaakovi <[email protected]> * Update Packs/Workday/Integrations/Workday/Workday.py Co-authored-by: Shai Yaakovi <[email protected]> * Changed verion in README.md * CR Changes * Secrets * Updated * CR changes Added Workday TPB to skipped tests (lack of access) * Update docker image Co-authored-by: Shai Yaakovi <[email protected]> Co-authored-by: Alex Fiedler <[email protected]> * pan-os-edl-docs1 (#7510) * Revert base fix (#7717) * revert 1.0.11 and 1.0.12 versions in Base pack by issuing version 1.0.13 * skiping XDR iocs test (#7719) Co-authored-by: esharf <[email protected]> * Workday - rm TODO lines (#7720) * rm todo * SlackAsk readme - add missing arguments (#7650) * added missing arguments to the README. * docker * fix * Updated * correction * merge * RN * no RN Co-authored-by: Alex Fiedler <[email protected]> * fix typo in integration name (#7698) * bump version 20.6.1 (#7722) * PAN-OS - Added outputs to the `panorama-get-logs` command (#7554) * PAN-OS - Added outputs to the `panorama-get-logs` command * dockerimage update * Update Packs/PAN-OS/ReleaseNotes/1_1_0.md Co-authored-by: Andrew Shamah <[email protected]> Co-authored-by: Andrew Shamah <[email protected]> * Nightly parallel pack installation (#7693) * added multithreading to pack installation for nightly runs * fixed call error * fixed CR notes * added sleep after nightly pack installation * Update 1_1_10.md * CrowdStrike Falcon Streaming v2 - bug fixes and improvments (#7552) * disable session timeout, handle exception better, add log prints and store offset in context * bump docker image tag * output event dump to rawJSON * Updated * store sample events * fix mypy reports * remove unnecessary line from the readme * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.yml Co-authored-by: Guy Lichtman <[email protected]> * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/README.md Co-authored-by: Guy Lichtman <[email protected]> * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.py Co-authored-by: Guy Lichtman <[email protected]> * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/README.md Co-authored-by: Guy Lichtman <[email protected]> * update readme that events are fetched every 1 minute * store integration context every 1 min and check if param is enabled in get samples cmd * remove unused import of union * Updated * Updated * reset last_integration_context_set to now after context set Co-authored-by: Alex Fiedler <[email protected]> Co-authored-by: Guy Lichtman <[email protected]> * Flake8 phase15 (#7707) * Traps flake8 * MailSenderNew_test flake8 * comment rn * flake8 phase 13 (#7705) * ZScalar, PcapMinerV2, QuestKace, Zsacalar, DBotSuggestClassifierMapping, ExtractDomainFromUrlFormat_test flake8 fixes * base rns * fixed typo * fix rn * fix rn * fix metada * comment rn Co-authored-by: Dan Tavori <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: content-bot <[email protected]> Co-authored-by: Guillermo Serrano <[email protected]> Co-authored-by: Bar Katzir <[email protected]> Co-authored-by: bar katzir <[email protected]> Co-authored-by: Bargenish <[email protected]> Co-authored-by: Shai Yaakovi <[email protected]> Co-authored-by: Alex Fiedler <[email protected]> Co-authored-by: Andrew Shamah <[email protected]> Co-authored-by: eli sharf <[email protected]> Co-authored-by: esharf <[email protected]> Co-authored-by: Lior Blobstein <[email protected]> Co-authored-by: Bar Hochman <[email protected]> Co-authored-by: roysagi <[email protected]> Co-authored-by: Guy Lichtman <[email protected]>
BenSterenson
pushed a commit
to BenSterenson/content
that referenced
this pull request
Jul 12, 2020
* creating workday pack * Worker context build function * Integration Ready but README.md, fine-tuning on unitests and TPB * Added Unittests and README.md * * Removed "Business_Title" from headers * Changed `Phone Number` field source. (and changed expected context accordingly) * Changed Test_module output * Changed username and password params to credentials type. in Workday.yml * Changed TPB according to Shai's review in Workday_-_Test.yml * Added TPB details to conf.json Co-authored-by: Shai Yaakovi <[email protected]> * Update Packs/Workday/Integrations/Workday/Workday.py Co-authored-by: Shai Yaakovi <[email protected]> * Changed verion in README.md * CR Changes * Secrets * Updated * CR changes Added Workday TPB to skipped tests (lack of access) * Update docker image Co-authored-by: Shai Yaakovi <[email protected]> Co-authored-by: Alex Fiedler <[email protected]>
BenSterenson
pushed a commit
to BenSterenson/content
that referenced
this pull request
Jul 12, 2020
* add test for get_msg_mail_format with headers set to none * catch all types of exceptions raised in get_msg_format * New RN summary (demisto#7133) * in progress * in progress * in progress * in progress * in progress * in progress * in progress * in progress * changed RN file name * added comments * test in progress * updated script * updated script * updated script * test fix helloworld * in progress * in progress * in progress * in progress * in progress * in progress * in progress * added test * fix * fixed doc * in progress * updated new release notes generator * in progress * in progress * in progress * in progress * fixed ignored release notes validations and added tests * small fixes * restored .gitignore * added new packs to release notes generator * fixed unit tests * fixed lint error * fixed lint error * fixed modified packs collection * Fixed handling of ignored section in RN files * fixed modified release notes filter * start merging pack versions block to single block * added support for merging pack versions block to single block * added unit test for merge release notes block function * fixed small formatting issue * fixed CR notes * fixed content-descriptor.json path * fixed time formats in content-descriptor.json Co-authored-by: syaakovi <[email protected]> * Microsoft azure feed (demisto#7715) * Microsoft azure feed (demisto#7410) * Add pack Azure AD Connect Health Feed * Clean up * Passed all tests * Fix test playbook * Minor fixes * Minor changes * remove changelog * change integration name global * include integration name in demisto.info * add docstring to substitution function * add disclaimer to readme * remove the other changelog * add command_examples.txt and generate readme with demisto-sdk * remove entries in tests/conf.json * remove urls from readme as it fails secrets test * remove trailing space * add entries back to conf.json as it fails pre-commit otherwise * remove exept blocks and apply suggestion to subs function * add suggested changes * Fix issue with results dict * changes to avoid duplicated indicators * remove substitution function as it's not deded Co-authored-by: Bar Katzir <[email protected]> * chnge taskid task.id TO UUIDS Co-authored-by: Guillermo Serrano <[email protected]> Co-authored-by: Bar Katzir <[email protected]> Co-authored-by: bar katzir <[email protected]> * Workday (demisto#7478) * creating workday pack * Worker context build function * Integration Ready but README.md, fine-tuning on unitests and TPB * Added Unittests and README.md * * Removed "Business_Title" from headers * Changed `Phone Number` field source. (and changed expected context accordingly) * Changed Test_module output * Changed username and password params to credentials type. in Workday.yml * Changed TPB according to Shai's review in Workday_-_Test.yml * Added TPB details to conf.json Co-authored-by: Shai Yaakovi <[email protected]> * Update Packs/Workday/Integrations/Workday/Workday.py Co-authored-by: Shai Yaakovi <[email protected]> * Changed verion in README.md * CR Changes * Secrets * Updated * CR changes Added Workday TPB to skipped tests (lack of access) * Update docker image Co-authored-by: Shai Yaakovi <[email protected]> Co-authored-by: Alex Fiedler <[email protected]> * pan-os-edl-docs1 (demisto#7510) * Revert base fix (demisto#7717) * revert 1.0.11 and 1.0.12 versions in Base pack by issuing version 1.0.13 * skiping XDR iocs test (demisto#7719) Co-authored-by: esharf <[email protected]> * Workday - rm TODO lines (demisto#7720) * rm todo * SlackAsk readme - add missing arguments (demisto#7650) * added missing arguments to the README. * docker * fix * Updated * correction * merge * RN * no RN Co-authored-by: Alex Fiedler <[email protected]> * fix typo in integration name (demisto#7698) * bump version 20.6.1 (demisto#7722) * PAN-OS - Added outputs to the `panorama-get-logs` command (demisto#7554) * PAN-OS - Added outputs to the `panorama-get-logs` command * dockerimage update * Update Packs/PAN-OS/ReleaseNotes/1_1_0.md Co-authored-by: Andrew Shamah <[email protected]> Co-authored-by: Andrew Shamah <[email protected]> * Nightly parallel pack installation (demisto#7693) * added multithreading to pack installation for nightly runs * fixed call error * fixed CR notes * added sleep after nightly pack installation * Update 1_1_10.md * CrowdStrike Falcon Streaming v2 - bug fixes and improvments (demisto#7552) * disable session timeout, handle exception better, add log prints and store offset in context * bump docker image tag * output event dump to rawJSON * Updated * store sample events * fix mypy reports * remove unnecessary line from the readme * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.yml Co-authored-by: Guy Lichtman <[email protected]> * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/README.md Co-authored-by: Guy Lichtman <[email protected]> * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.py Co-authored-by: Guy Lichtman <[email protected]> * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/README.md Co-authored-by: Guy Lichtman <[email protected]> * update readme that events are fetched every 1 minute * store integration context every 1 min and check if param is enabled in get samples cmd * remove unused import of union * Updated * Updated * reset last_integration_context_set to now after context set Co-authored-by: Alex Fiedler <[email protected]> Co-authored-by: Guy Lichtman <[email protected]> * Flake8 phase15 (demisto#7707) * Traps flake8 * MailSenderNew_test flake8 * comment rn * flake8 phase 13 (demisto#7705) * ZScalar, PcapMinerV2, QuestKace, Zsacalar, DBotSuggestClassifierMapping, ExtractDomainFromUrlFormat_test flake8 fixes * base rns * fixed typo * fix rn * fix rn * fix metada * comment rn Co-authored-by: Dan Tavori <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: content-bot <[email protected]> Co-authored-by: Guillermo Serrano <[email protected]> Co-authored-by: Bar Katzir <[email protected]> Co-authored-by: bar katzir <[email protected]> Co-authored-by: Bargenish <[email protected]> Co-authored-by: Shai Yaakovi <[email protected]> Co-authored-by: Alex Fiedler <[email protected]> Co-authored-by: Andrew Shamah <[email protected]> Co-authored-by: eli sharf <[email protected]> Co-authored-by: esharf <[email protected]> Co-authored-by: Lior Blobstein <[email protected]> Co-authored-by: Bar Hochman <[email protected]> Co-authored-by: roysagi <[email protected]> Co-authored-by: Guy Lichtman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: demisto/etc/issues/9539
Description
Integration with Workday
Screenshots
Paste here any images that will help the reviewer
Minimum version of Demisto
Does it break backward compatibility?
Must have
Demisto Partner?