Skip to content

NozomiGuardian Integration Same As Closed PR #7112 #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

NozomiGuardian Integration Same As Closed PR #7112 #7529

merged 1 commit into from
Jun 22, 2020

Conversation

ayman-m
Copy link
Contributor

@ayman-m ayman-m commented Jun 11, 2020

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Demisto

  • 4.5.0
  • [x ] 5.0.0
  • 5.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • [ x] Tests
  • [ x] Documentation

Demisto Partner?

  • The title must be in the following format: [YOUR_PARTNER_ID] short description

@ayman-m
Copy link
Contributor Author

ayman-m commented Jun 11, 2020

@yaakovi I hope this one works, I can see only one commit pushed now

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Jun 11, 2020
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @anara123 will very shortly look over your proposed changes.

@content-bot content-bot requested a review from anara123 June 11, 2020 18:34
@content-bot
Copy link
Collaborator

The CircleCI check from your latest pushed commit was unsuccessful. @ayman-m take a look at the build by clicking this link.

Failed Build Steps

  • Validate Files and Yaml
  • Collect Test List And Content Packs
  • Prepare Content Packs For Testing

Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you.

@yaakovi yaakovi requested review from yaakovi and removed request for anara123 June 16, 2020 05:54
@yaakovi yaakovi assigned yaakovi and unassigned anara123 Jun 16, 2020
yaakovi
yaakovi approved these changes Jun 16, 2020
View reviewed changes
Packs/NozomiNetworks/TestPlaybooks/playbook-NozomiGuardian_Test.yml
id: NozomiGuardian-Test
name: NozomiGuardian-Test
version: -1
fromversion: 4.5.0
Copy link
Contributor

@yaakovi yaakovi Jun 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration has fromversion: 5.0.0

Suggested change
fromversion: 4.5.0
description: ''
fromversion: 5.0.0

@yaakovi
Copy link
Contributor

yaakovi commented Jun 16, 2020

@kirbles19 please review integration YML and README

yaakovi
yaakovi reviewed Jun 16, 2020
View reviewed changes
Packs/NozomiNetworks/Integrations/NozomiGuardian/NozomiGuardian.yml
script: '-'
subtype: python3
type: python
fromversion: 5.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fromversion: 5.0.0
fromversion: 5.0.0
tests:
- NozomiGuardian-Test

@kirbles19
Copy link
Contributor

@yaakovi Done.

@yaakovi yaakovi merged commit 95e03ae into demisto:contrib/my-soar_nozomi Jun 22, 2020
@yaakovi
Copy link
Contributor

yaakovi commented Jun 22, 2020

will fix the build errors in the base branch

@content-bot content-bot mentioned this pull request Jun 22, 2020
Merged
8 tasks
yaakovi added a commit that referenced this pull request Jun 22, 2020
@content-bot @ayman-m
@aymansm @yaakovi
NozomiGuardian Integration Same As Closed PR #7112 (#7701)
02f1f59 
* Initial Commit (#7529)

Co-authored-by: Ayman <[email protected]>

* fixed missing description and wrong version

* fixed descriptions suggested by tech writer

* updated docker image

* skip integration - no instance

Co-authored-by: Ayman Mahmoud <[email protected]>
Co-authored-by: Ayman <[email protected]>
Co-authored-by: syaakovi <[email protected]>
BenSterenson pushed a commit to BenSterenson/content that referenced this pull request Jul 12, 2020
@content-bot @ayman-m
@aymansm @yaakovi
NozomiGuardian Integration Same As Closed PR demisto#7112 (demisto#7701)
01d0c28 
* Initial Commit (demisto#7529)

Co-authored-by: Ayman <[email protected]>

* fixed missing description and wrong version

* fixed descriptions suggested by tech writer

* updated docker image

* skip integration - no instance

Co-authored-by: Ayman Mahmoud <[email protected]>
Co-authored-by: Ayman <[email protected]>
Co-authored-by: syaakovi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakovi yaakovi yaakovi approved these changes

Assignees

@yaakovi yaakovi

@kirbles19 kirbles19

Labels
Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ayman-m @content-bot @yaakovi @kirbles19 @anara123 @aymansm