Sane doc reports #7641
Sane doc reports #7641
Conversation
| @@ -1,5 +1,5 @@ | |||
| ## [Unreleased] | |||
|
|
|||
| - Updating sane doc reports and adding customer logo. | |||
There was a problem hiding this comment.
Please use the new release notes format
demisto-sdk update-release-notes
There was a problem hiding this comment.
Starting to update release notes.
No changes were detected.
?
There was a problem hiding this comment.
@amshamah419 can you take a look at this?
There was a problem hiding this comment.
@agamm Can you try updating your demisto-sdk?
There was a problem hiding this comment.
@ronykoz @amshamah419 I updated before:
(Already tried: pip3 install --upgrade demisto-sdk) anything I need to change in the code / make changes ?
| 'utf-8') | ||
| paper_size = demisto.args().get('paperSize', 'A4').encode( | ||
| 'utf-8') | ||
| orientation = demisto.args().get('orientation', 'portrait') |
There was a problem hiding this comment.
why did you remove the encoding?
There was a problem hiding this comment.
I don't think there was a need, unless you think there are times it will be affected?
There was a problem hiding this comment.
tbh i'm not 100% sure, let's add this to be on the safe side
There was a problem hiding this comment.
Is this a convention in content?
I remember that it works ok in pdf reports:
(at least most of them).
Maybe @glicht do you have an idea why we need to encode utf8?
There was a problem hiding this comment.
If the docker image is python3 we don't need it
|
Thanks @amshamah419 ! |
Status
Related Issues
fixes: #1836
Description
Screenshots
--Minimum version of Demisto
Does it break backward compatibility?
Must have
Demisto Partner?