Fixed DT syntax error #7909
Merged
Fixed DT syntax error #7909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
changed the base branch from
master
to
contrib/aburt-demisto_aburt-netopsPB-change
|
Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @liorblob will very shortly look over your proposed changes. |
|
@aburt-demisto Why make all of the operators |
|
|
You can keep it however you like. The issue is not the !== or !=. It is the
incorrect enclosure of the second parameters that makes my DT fail. The
last 3 calls to GenericPolling have the second parameter enclosed in a
bracket that I can't replicate on my keyboard. I suspect that is why it is
failing and have tested the DT copying and pasting with a manual DT command
and it fails. I then change the quotation marks to single ' and all is fine.
Dealers choice on the != vs !== however it would be nice if it was
consistent.
Regards
Adam
Adam Burt | Mgr, Solutions Architecture • EMEA
Mobile: +44(0) 7713 363155 | www.paloaltonetworks.com
<https://www.paloaltonetworks.com/>
Email: [email protected]
<https://www.paloaltonetworks.com/cortex>
<https://www.linkedin.com/company/palo-alto-networks>
<https://www.facebook.com/PaloAltoNetworks/>
The content of this message is the proprietary and confidential property of
Palo Alto Networks, and should be treated as such. If you are not the
intended recipient and have received this message in error, please delete
this message from your computer system and notify me immediately by reply
e-mail. Any unauthorized use or distribution of the content of this message
is prohibited.
…On Wed, Jul 8, 2020 at 4:18 PM Lior Blobstein ***@***.***> wrote:
1. DT is in javascript
2. !== is more strict than != and should work. See
https://stackoverflow.com/questions/359494/which-equals-operator-vs-should-be-used-in-javascript-comparisons
<https://urldefense.proofpoint.com/v2/url?u=https-3A__stackoverflow.com_questions_359494_which-2Dequals-2Doperator-2Dvs-2Dshould-2Dbe-2Dused-2Din-2Djavascript-2Dcomparisons&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=SfBamao7x1OJ-Jmqv1HgHELJJWxQc4P2RW91K_ljPZE&m=1SMHgpSeuBikuN4SsLX3aPPAZrtAyQ1LUadAI5JtyMY&s=KlGMxQ82Vk-o8m8Na7sA8BMUDCotAISJpnPWN-c_4hc&e=>
3. if it does not work and != works please try to understand why.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_7909-23issuecomment-2D655584539&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=SfBamao7x1OJ-Jmqv1HgHELJJWxQc4P2RW91K_ljPZE&m=1SMHgpSeuBikuN4SsLX3aPPAZrtAyQ1LUadAI5JtyMY&s=DHMtUvvL4NlD-_C6oJLH99JNTorjXE8JuRBgss5TU_Y&e=>,
or unsubscribe
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMYYDQPOUGXG7MAAOXFXSD3R2SE3HANCNFSM4OTH3VMA&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=SfBamao7x1OJ-Jmqv1HgHELJJWxQc4P2RW91K_ljPZE&m=1SMHgpSeuBikuN4SsLX3aPPAZrtAyQ1LUadAI5JtyMY&s=S1rvE7qISRojFirorZJZoFkzkTCvJgL3lkktS4NCGbA&e=>
.
|
|
Can you please change it to be |
|
Thanks. |
|
:o( .....
File "/usr/local/bin/demisto-sdk", line 8, in <module>
sys.exit(main())
File "/home/adam/.local/lib/python3.7/site-packages/click/core.py", line
764, in __call__
return self.main(*args, **kwargs)
File "/home/adam/.local/lib/python3.7/site-packages/click/core.py", line
717, in main
rv = self.invoke(ctx)
File "/home/adam/.local/lib/python3.7/site-packages/click/core.py", line
1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/adam/.local/lib/python3.7/site-packages/click/core.py", line
956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/adam/.local/lib/python3.7/site-packages/click/core.py", line
555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/demisto_sdk/__main__.py",
line 811, in update_pack_releasenotes
update_pack_rn.execute_update()
File
"/usr/local/lib/python3.7/dist-packages/demisto_sdk/commands/update_release_notes/update_rn.py",
line 62, in execute_update
rn_string = self.build_rn_template(changed_files)
File
"/usr/local/lib/python3.7/dist-packages/demisto_sdk/commands/update_release_notes/update_rn.py",
line 258, in build_rn_template
for k, v in sorted(changed_items.items(), key=lambda x: x[1]):
TypeError: '<' not supported between instances of 'str' and 'NoneType'
demisto-sdk threw an error.
Adam Burt | Mgr, Solutions Architecture • EMEA
Mobile: +44(0) 7713 363155 | www.paloaltonetworks.com
<https://www.paloaltonetworks.com/>
Email: [email protected]
<https://www.paloaltonetworks.com/cortex>
<https://www.linkedin.com/company/palo-alto-networks>
<https://www.facebook.com/PaloAltoNetworks/>
The content of this message is the proprietary and confidential property of
Palo Alto Networks, and should be treated as such. If you are not the
intended recipient and have received this message in error, please delete
this message from your computer system and notify me immediately by reply
e-mail. Any unauthorized use or distribution of the content of this message
is prohibited.
…On Thu, Jul 9, 2020 at 12:09 PM Lior Blobstein ***@***.***> wrote:
Thanks.
One last thing, can you run demisto-sdk update-release-notes -p PAN-OS -u
revision to update the release notes for the pack?
make sure to update the added file under the ReleaseNotes directory
inside the pack.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_7909-23issuecomment-2D656064414&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=SfBamao7x1OJ-Jmqv1HgHELJJWxQc4P2RW91K_ljPZE&m=FGxoyFqnUK11wtGI4A6RCnanI8zrOka-hQV0J2KoKkk&s=DQ1gu4B432_IQ4pfEmdpPLW7mV-6wAMu0XKWUcs09H4&e=>,
or unsubscribe
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMYYDQL4K66PBAF642KOAZLR2WQOFANCNFSM4OTH3VMA&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=SfBamao7x1OJ-Jmqv1HgHELJJWxQc4P2RW91K_ljPZE&m=FGxoyFqnUK11wtGI4A6RCnanI8zrOka-hQV0J2KoKkk&s=jU49xxfvmVtnSZQDsy-JD1XrZ1K8BIPjClG5_US2kEM&e=>
.
|
|
I guess that's on us. I'll take care of it |
liorblob
approved these changes
Jul 9, 2020
Merged
yuvalbenshalom
added a commit
that referenced
this pull request
Jul 10, 2020
* Fixed DT syntax error (#7909) * Fixed DT syntax error * Fixed DT syntax error * Fixed DT syntax error Co-authored-by: Adam Burt - Demisto <[email protected]> * change * unreleased * RN * fix version in pack_metadata.json * fix RN after review Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: ybenshalom <[email protected]>
BenSterenson
pushed a commit
to BenSterenson/content
that referenced
this pull request
Jul 12, 2020
* Fixed DT syntax error (demisto#7909) * Fixed DT syntax error * Fixed DT syntax error * Fixed DT syntax error Co-authored-by: Adam Burt - Demisto <[email protected]> * change * unreleased * RN * fix version in pack_metadata.json * fix RN after review Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: ybenshalom <[email protected]>
hod-alpert
pushed a commit
that referenced
this pull request
Jul 19, 2020
* Fixed DT syntax error (#7909) * Fixed DT syntax error * Fixed DT syntax error * Fixed DT syntax error Co-authored-by: Adam Burt - Demisto <[email protected]> * change * unreleased * RN * fix version in pack_metadata.json * fix RN after review Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: ybenshalom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://github.com/demisto/etc/issues/26310
Description
DT Syntax modified in NetOps playbook that is causing failure of status ID captures.
Minimum version of Demisto
Does it break backward compatibility?
Must have