[code42-363] Add Else to Download File playbook and upgrade docker file #8814

antazoey · 2020-09-03T22:45:06Z

XSOAR Partner?

The title must be in the following format: [YOUR_PARTNER_ID] short description.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

Issue from slack partner channel.

Description

Adds missing else case to the Code42 Download File Playbook, formats the playbook. These changes also update the py42 dockerfile and use the newly available constants.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Demisto

5.0.0
5.5.0
6.0.0

Does it break backward compatibility?

Yes
- Further details:
No

Must have

Tests
Documentation

Add results param to get all

reutshal

Hi @unparalleled-js!
Overall looking great.
When can we schedule a quick demo with you?
@mayagoldb FYI

content-bot · 2020-09-09T08:47:04Z

Instance is ready. Server link: https://ec2-34-218-81-36.us-west-2.compute.amazonaws.com, Build link: https://circleci.com/gh/demisto/content/117091

antazoey · 2020-09-09T13:46:28Z

Hi @unparalleled-js!
Overall looking great.
When can we schedule a quick demo with you?
@mayagoldb FYI

Early mornings my time is 15:00 - 17:00 Israel time, which is good for me, any day.
Note that it will be a simple demo. The only changes are bug fixes and a formerly-missing Else condition

mayagoldb · 2020-09-13T14:09:10Z

@unparalleled-js
Comments about the playbook:

The else case you should add is for the Is Code42 Integration Active?, so if the integration is not active it will finish the playbook's run. In the PR you added a link from the trigger to the end task which should be removed.

antazoey · 2020-09-14T13:10:59Z

@unparalleled-js
Comments about the playbook:

The else case you should add is for the Is Code42 Integration Active?, so if the integration is not active it will finish the playbook's run. In the PR you added a link from the trigger to the end task which should be removed.

Whoops! Okay, it is correct now.

* [code42-363] Add Else to Download File playbook and upgrade docker file (#8814) * Current file * Add fetch + new commands to test playbook * Delete unused pb * corrections * SavE * Handle str results * Save * New cmd outputs results * Save * Command results * Add missing CL entries * Client create user * Save * Fix final test * Save * Use readable outputs var * Gen yml * Put back CaseID and alias UserID * Gen yml * Add new commands * Put back CL * Save * Add type * Gen readme * Unblock and reactivate * Finish adding commands * PR feedback + refactor * Format * Gen yml * Handle no results for detection list get alls * Fix tests * Use get as much as possible, per feedback * Add simple playbooks * Lint * Fix from validate command * Put back name * More straightening up * Clean up * Share exception * Format * Save * Make params required * Save * Remove unneeded try catches * gen yml * Test dwnld file * Shared errors * Anomalize * Add links to image * save * Chunks * Lint * lint * lint * Download file pb * Remove params from a test that arent used * Update exil pb * Playbooks * Add missing cl * Use correct checksum from incident * Add evidence and ignore errors for file download * Remove outputs * Fix description * Fix ID * Fix validation errorS * Fix validation errors * Fix validation error * Fix validation error * Removed integration file - not supposed to be there i guess * Update release notes and fix validation:: * Remove breaking change i guess * make username not required to keep back compat :( * unify * remove debug stmnts * unify * Fix playbook * Fix validation errors * anonimize ips * readme * WIP * Use enum * Add outside trusted domains to predefined exposure type list for fetch * Slight refactor * Rename var * Not files * Remove integ file * Undo accident * changelog fix * Call isinstance only once * Simplify command * Empty committ * added commands departingemployee-get and highriskemployee-get * Use filename * Flake8 * Remove test ips * Conform to comma delimited * List opts * Fix tests * Test code improvements * added tests * refactor * Added documentation and changelog * legal hold remove * gen docs * remove rel import * client tests * finish tests * put back examples * remove itegration.yml * fix description * add changelog * fix typo * fix empty or None matter name * add missing decorators * remove itegration.yml * remove itegration.yml * Added command yaml * Save * _ to - * Remove playbooks * hr last 30 days * Save * Fix to say comma delim instead of space * add outputs and generate docs * remove itegration.yml * Remove paid content * Update search alerts * Test * fix tests * Filter type param to de get all * Add support for exposure type exists criteria when no exposure type is specified * remove check for mattername * Address PR Feedback * Missing test * adjust test * Remove alert search from pr * Remove readme changes * Remove unused import * Add leaving today option * Default value enforcements * fix lint error * Resolve conflicts * Flake8 * Case conform * Put back? * fix mock * fix lint errors * To search for all exposure types specify all option * Fix * Update docker image and master * Added changelog * update docker image * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> * [code42-636] Bump py42 dependency docker container (#8257) * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> Co-authored-by: reut shalem <[email protected]> * Add desc to email * Update readme * Match descs * [code42-636] Improve documentation examples (#8305) * Remove whitespace in yml * Gen yml * Main * Tags * Handle unsupported ets better * Fix comment * Gen yml * New fields * Update views * Handle test command better * Gen yml * Adjust comment * lint * gen yml * savE * Test outputs * Use test id * move and use file events mapping * Create details widget * Save * Add params * Add results param * Fix hr add desc * Handle list risk tags for 2 cmds{ * Update descs * Handle none possibilities for dict gets * Current file * Add fetch + new commands to test playbook * Delete unused pb * corrections * SavE * Handle str results * Save * New cmd outputs results * Save * Command results * Add missing CL entries * Client create user * Save * Fix final test * Save * Use readable outputs var * Gen yml * Put back CaseID and alias UserID * Gen yml * Add new commands * Put back CL * Save * Add type * Gen readme * Unblock and reactivate * Finish adding commands * PR feedback + refactor * Format * Gen yml * Handle no results for detection list get alls * Fix tests * Use get as much as possible, per feedback * Add simple playbooks * Lint * Fix from validate command * Put back name * More straightening up * Clean up * Share exception * Format * Save * Make params required * Save * Remove unneeded try catches * gen yml * Test dwnld file * Shared errors * Anomalize * Add links to image * save * Chunks * Lint * lint * lint * Download file pb * Remove params from a test that arent used * Update exil pb * Playbooks * Add missing cl * Use correct checksum from incident * Add evidence and ignore errors for file download * Remove outputs * Fix description * Fix ID * Fix validation errorS * Fix validation errors * Fix validation error * Fix validation error * Removed integration file - not supposed to be there i guess * Update release notes and fix validation:: * Remove breaking change i guess * make username not required to keep back compat :( * unify * remove debug stmnts * unify * Fix playbook * Fix validation errors * anonimize ips * readme * WIP * Use enum * Add outside trusted domains to predefined exposure type list for fetch * Slight refactor * Rename var * Not files * Remove integ file * Undo accident * changelog fix * Call isinstance only once * Simplify command * Empty committ * added commands departingemployee-get and highriskemployee-get * Use filename * Flake8 * Remove test ips * Conform to comma delimited * List opts * Fix tests * Test code improvements * added tests * refactor * Added documentation and changelog * legal hold remove * gen docs * remove rel import * client tests * finish tests * put back examples * remove itegration.yml * fix description * add changelog * fix typo * fix empty or None matter name * add missing decorators * remove itegration.yml * remove itegration.yml * Added command yaml * Save * _ to - * Remove playbooks * hr last 30 days * Save * Fix to say comma delim instead of space * add outputs and generate docs * remove itegration.yml * Remove paid content * Update search alerts * Test * fix tests * Filter type param to de get all * Add support for exposure type exists criteria when no exposure type is specified * remove check for mattername * Address PR Feedback * Missing test * adjust test * Remove alert search from pr * Remove readme changes * Remove unused import * Add leaving today option * Default value enforcements * fix lint error * Resolve conflicts * Flake8 * Case conform * Put back? * fix mock * fix lint errors * To search for all exposure types specify all option * Fix * Update docker image and master * Added changelog * update docker image * bump py42 docker container * fix test * fix ci * Update Packs/Code42/ReleaseNotes/2_0_1.md Co-authored-by: reut shalem <[email protected]> * Add desc to email * Update readme * Match descs Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> * Use mapping * Update docker container * Reuse code and renames * Test source code case * bumped docker version * Fix test * Release notes (#32) * Update release notes * CL * Copy cl entry to rn * Remove unused method * Delete tmp file * Code42/update py42 dep (#34) * Update docker tag * Use FileCategory constants * Use Detection List filter constants * Update release notes * Update release notes * Format playbook * Correct release notes * Remove unneeded s from release notes, typo * Handle lowercase pdf * Handle all cases better * Handle all the cases * Remove commented out code * Lessen coment * Update release notes * Rm extra space in release notes * Put else statement on correct Task Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: reut shalem <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: ShahafBenYakir <[email protected]> * Update 2_0_4.md * Update 2_0_4.md Co-authored-by: Juliya Smith <[email protected]> Co-authored-by: Alan Grgic <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: Kiran Chaudhary <[email protected]> Co-authored-by: syaakovi <[email protected]> Co-authored-by: ShahafBenYakir <[email protected]> Co-authored-by: roysagi <[email protected]>

Juliya Smith added 30 commits June 26, 2020 16:11

Merge branch 'master' into field-mappings

720fda7

Resolve flictS

6acc254

Merge pull request #9 from code42/add-results-param-to-get-all

137a3a1

Add results param to get all

Resolve conflicts

be90bdb

Current file

706b0fe

Merge branch 'master' into test-fetch-playbook

26d1a8a

Add fetch + new commands to test playbook

50966d3

Delete unused pb

880a9b3

corrections

45329ad

Merge pull request #8 from code42/unit-test-command-outputs

29acfe3

Merge pull request #11 from code42/test-fetch-playbook

1e13e46

SavE

104c41f

Save

83264b8

Handle str results

541754f

Merge pull request #12 from code42/Fix-results

f0a9a1d

Save

940266c

Merge branch 'master' into CmdResults

04b9288

New cmd outputs results

3ec31a2

Save

9482189

Merge remote-tracking branch 'upstream/master'

f40394c

Command results

78deed2

Add missing CL entries

3d1d290

Merge branch 'CmdResults' into user-mgmt

8101569

Client create user

0e8e0f6

Save

f8d733a

Fix final test

76aedf7

Merge pull request #7 from code42/field-mappings

09270bb

Merge branch 'CmdResults' into user-mgmt

3c22f3b

Merge branch 'master' into user-mgmt

d18edbc

Merge branch 'master' into CmdResults

8717a62

Juliya Smith added 6 commits September 8, 2020 16:30

Handle all the cases

41f8468

Remove commented out code

51538d2

Lessen coment

d59b5f0

Update release notes

be1b8f8

Rm extra space in release notes

dc824fe

Merge pull request #35 from code42/handle-lower-case-pdf

0058956

reutshal reviewed Sep 9, 2020

View reviewed changes

reutshal added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Sep 9, 2020

mayagoldb self-requested a review September 9, 2020 11:05

reutshal added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Sep 9, 2020

reutshal added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Sep 13, 2020

Put else statement on correct Task

ecd030b

reutshal added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Sep 15, 2020

mayagoldb approved these changes Sep 15, 2020

View reviewed changes

reutshal approved these changes Sep 15, 2020

View reviewed changes

reutshal added the docs-approved label Sep 15, 2020

reutshal merged commit 4b216a2 into demisto:contrib/code42_master Sep 15, 2020

content-bot mentioned this pull request Sep 15, 2020

[code42-363] Add Else to Download File playbook and upgrade docker file #8972

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[code42-363] Add Else to Download File playbook and upgrade docker file #8814

[code42-363] Add Else to Download File playbook and upgrade docker file #8814

Uh oh!

antazoey commented Sep 3, 2020

Uh oh!

reutshal left a comment

Uh oh!

content-bot commented Sep 9, 2020 •

edited

Loading

Uh oh!

antazoey commented Sep 9, 2020 •

edited

Loading

Uh oh!

mayagoldb commented Sep 13, 2020

Uh oh!

antazoey commented Sep 14, 2020

Uh oh!

Uh oh!

[code42-363] Add Else to Download File playbook and upgrade docker file #8814

[code42-363] Add Else to Download File playbook and upgrade docker file #8814

Uh oh!

Conversation

antazoey commented Sep 3, 2020

XSOAR Partner?

Status

Related Issues

Description

Screenshots

Minimum version of Demisto

Does it break backward compatibility?

Must have

Uh oh!

reutshal left a comment

Choose a reason for hiding this comment

Uh oh!

content-bot commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antazoey commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mayagoldb commented Sep 13, 2020

Uh oh!

antazoey commented Sep 14, 2020

Uh oh!

Uh oh!

content-bot commented Sep 9, 2020 •

edited

Loading

antazoey commented Sep 9, 2020 •

edited

Loading