-
-
Notifications
You must be signed in to change notification settings - Fork 287
enhance: Leave trace on source note while using selectionExtract #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathanyeung
merged 5 commits into
master
from
enhance/leave-trace-on-source-note-using-selectionExtract
Sep 28, 2021
Merged
enhance: Leave trace on source note while using selectionExtract #1373
jonathanyeung
merged 5 commits into
master
from
enhance/leave-trace-on-source-note-using-selectionExtract
Sep 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikchoi
reviewed
Sep 23, 2021
hikchoi
reviewed
Sep 23, 2021
hikchoi
reviewed
Sep 23, 2021
hikchoi
suggested changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments on potential improvements 🙂
lgtm |
hikchoi
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# enhance(workspace) : Leave a trace on source note when using selectionExtract
PR for docs update: https://github.com/dendronhq/dendron-site/pulls
Pull Request Checklist
You can go to dendron pull requests to see full details for items in this checklist.
General
Quality Assurance
Special Cases
Docs
Example PR Description
Special Cases
First Time PR
Analytics