Skip to content

Conversation

Harshita-mindfire
Copy link
Contributor

@Harshita-mindfire Harshita-mindfire commented Sep 21, 2021

# enhance(workspace) : Leave a trace on source note when using selectionExtract

PR for docs update: https://github.com/dendronhq/dendron-site/pulls

Pull Request Checklist

You can go to dendron pull requests to see full details for items in this checklist.

General

Quality Assurance

  • add a test for the new feature
  • make sure all the existing tests pass
  • do a spot check by running your feature with our test workspace
  • after you submit your pull request, check the output of our integration test and make sure all tests pass
    • NOTE: if you running mac/linux, check the windows output and vice versa if you are developing on windows

Special Cases

  • [~] if your tests changes an existing snaphot, make sure that snapshots are updated
  • [~] if you are adding a new language feature (graphically visible in vscode/preview/publishing), make sure that it is included in test-workspace. We use this to manually inspect new changes and for auto regression testiing

Docs

  • Make sure that the PR title follows our commit style
  • Please summarize the feature or impact in 1-2 lines in the PR description
  • If your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR

Example PR Description

# feat: capitalize all foos

This changes capitalizes all occurences of `foo` to `Foo` 

Docs PR: <URL_TO_DOCS_PR>

Special Cases

First Time PR

  • [~] sign the CLA which will be prompted by our github bot after you submit the PR
  • [~] add your discord alias in the review so that we can give you the horticulturalist badge in our community

Analytics

  • [~] if you are adding analytics related changes, make sure the Telemetry docs are updated

Copy link
Contributor

@hikchoi hikchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on potential improvements 🙂

@jonathanyeung
Copy link
Contributor

lgtm

Copy link
Contributor

@hikchoi hikchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍🏼

@jonathanyeung jonathanyeung merged commit 3d83f1d into master Sep 28, 2021
@jonathanyeung jonathanyeung deleted the enhance/leave-trace-on-source-note-using-selectionExtract branch September 28, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants