Fix fork deletion for squashed/closed PRs#130
Open
azat-io wants to merge 3 commits into
Open
Conversation
Contributor
|
The support for squash merges is great, but I'm not sure about PRs that are closed without being merged. Personally I would typically not want to delete a fork with modifications that were not merged upstream. At least they should be presented separately to make sure the user doesn't delete them and lose work inadvertently. |
Author
|
@waldyrious Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash/rebase merges remove the original branch commits, so
compareCommitscould not detect merged work and forks weren’t offered for deletion.This change checks PR status first: merged/closed PRs mark the branch as not useful, open PRs keep the fork, and only then falls back to
compareCommits.Added tests for merged/closed/open PRs and for the no‑PR fallback case.