fix: support "other" event type in FSWatcher #12836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Nov 23, 2021
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
Any way we can test this addition?
Member
Author
See the PR description :-) |
Member
|
LGTM then |
kitsonk
reviewed
Nov 23, 2021
Member
Author
See PR description 😉 |
kitsonk
approved these changes
Nov 23, 2021
Contributor
kitsonk
left a comment
kitsonk
left a comment
There was a problem hiding this comment.
LGTM too, now that I actually read things.
dsherret
approved these changes
Nov 23, 2021
kt3k
approved these changes
Nov 23, 2021
piscisaureus
pushed a commit
that referenced
this pull request
Nov 24, 2021
This commit adds support for "other" events in `FSWatcher`. Flags on events are now exposed via the `flag` property on `FsEvent`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for "other" events in
FSWatcher. Flags onevents are now exposed via the
flagproperty onFsEvent.There are no tests for this change, as the only known cause for this
"other"event being emitted, is watching an SMB share on macOS. Not something we can
really test for in CI.
Closes #12097