Repository navigation
fix(test): add slice method to filename - #16482
Merged
Merged
Conversation
|
|
shogohida
marked this pull request as ready for review
October 30, 2022 06:59
shogohida
changed the title
magurotuna
self-requested a review
October 30, 2022 15:57
magurotuna
approved these changes
Oct 31, 2022
magurotuna
left a comment
magurotuna
left a comment
Member
There was a problem hiding this comment.
LGTM - Good fix :) Thanks for your first contribution!
Contributor
Author
|
Thanks for approving my PR! Your support helped me a lot! Hope to contribute more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16305
I referred to event_listener_error_handled and set_timeout_error_handled