Skip to content

Make window compatible with ts 3.6 #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ry merged 2 commits into from
Sep 19, 2019
Merged

Make window compatible with ts 3.6 #2984

ry merged 2 commits into from
Sep 19, 2019

Conversation

@justjavac
Copy link
Contributor

@justjavac justjavac commented Sep 19, 2019 •
edited
Loading

see microsoft/TypeScript#32335

https://devblogs.microsoft.com/typescript/announcing-typescript-3-6/#dom-updates

The global window is no longer defined as type Window – instead, it is defined as type Window & typeof globalThis. In some cases, it may be better to refer to its type as typeof window.

fixed #2669

ry
ry reviewed Sep 19, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally added //build

@justjavac justjavac force-pushed the fix-deno-runtime-types branch from 0388178 to 44e4354 Compare September 19, 2019 06:27
kitsonk
kitsonk reviewed Sep 19, 2019
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justjavac justjavac force-pushed the fix-deno-runtime-types branch from 7177e7b to f19c583 Compare September 19, 2019 11:11
@ry ry merged commit 1b1ae65 into denoland:master Sep 19, 2019
@justjavac justjavac deleted the fix-deno-runtime-types branch October 11, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ry ry ry approved these changes

+1 more reviewer

@kitsonk kitsonk kitsonk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot access certain globalThis properties in .ts files

3 participants

@justjavac @ry @kitsonk