Skip to content

fix(coverage): ignore unmappable V8 ranges - #37033

Draft
FOWEPJF255 wants to merge 2 commits into
denoland:mainfrom
FOWEPJF255:codex/fix-37007-coverage-offsets
Draft

FOWEPJF255 wants to merge 2 commits into
denoland:mainfrom
FOWEPJF255:codex/fix-37007-coverage-offsets

Conversation

@FOWEPJF255

Copy link
Copy Markdown

Fixes #37007

Summary

  • Ignore V8 coverage ranges that cannot map to valid UTF-8 boundaries in the runtime source.
  • Reject oversized UTF-16 offsets before converting them to TextSize.
  • Add regression tests for out-of-range, oversized, and surrogate-pair-interior offsets.

Validation

  • cargo fmt --manifest-path cli/Cargo.toml -- --check passed.
  • git diff --check passed.
  • The focused Cargo test was attempted but stopped before compiling the crate because this Windows environment lacks link.exe. The commit includes [ci] so hosted CI runs the full checks.

AI assistance was used for investigation and implementation; the code and tests were reviewed before submission.

Ignore coverage ranges that cannot map to valid UTF-8 boundaries in the runtime source. This keeps report generation safe when V8 offsets are stale or inconsistent.

Fix denoland#37007
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deno Panic while testing

2 participants