Skip to content

Conversation

@petamoriken
Copy link
Contributor

@petamoriken
Copy link
Contributor Author

Oh, we need to support dynamic imports

@petamoriken petamoriken marked this pull request as draft November 14, 2023 15:21
@petamoriken petamoriken marked this pull request as ready for review November 14, 2023 17:01
@petamoriken petamoriken changed the title feat: add no-import-assetions rule feat: add no-import-assertions rule Nov 14, 2023
@petamoriken
Copy link
Contributor Author

@magurotuna Please take a look!

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this.

@dsherret dsherret merged commit 0bebdcd into denoland:main Nov 20, 2023
@petamoriken petamoriken deleted the feat/no-import-assetions branch November 20, 2023 23:37
@magurotuna
Copy link
Member

Sorry I overlooked your notification @petamoriken, and thank you for reviewing David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants