Skip to content

fix: nullish coalescing operator conditional detection #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 2 commits into from
Mar 6, 2025
Merged

fix: nullish coalescing operator conditional detection #1427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db52465
fix: nullish coalescing operator conditional detection
paul-sachs Mar 4, 2025
9b69bd7
chore: add more test cases
marvinhagemeister Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/rules/react_rules_of_hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,13 @@ impl Handler for RulesOfHooksHandler {
}
}
}
Node::BinExpr(_) => {
if let Some(ParentKind::Bin) = self.parent_kind.pop() {
Copy link
Contributor Author

@paul-sachs paul-sachs Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is even really needed, might be excessive paranoia.

self.maybe_decrease_cond_counter();
}
}
Node::FnDecl(_)
| Node::ArrowExpr(_)
| Node::BinExpr(_)
| Node::CondExpr(_)
| Node::VarDeclarator(_)
| Node::ForInStmt(_)
Expand Down Expand Up @@ -334,6 +338,22 @@ function doAThing() {
}
const [foo, setFoo] = useState(false);
}"#,
r#"function Foo() {
useCustomHook(val ?? 0);
useState(0);
}"#,
r#"function Foo() {
useCustomHook(val && 0);
useState(0);
}"#,
r#"function Foo() {
useCustomHook(val || 0);
useState(0);
}"#,
r#"function Foo() {
useCustomHook(val > 0);
useState(0);
}"#,
};
}

Expand Down