Skip to content

fix(logs): support project name in positional argument #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magurotuna merged 2 commits into from
Sep 12, 2023
Merged

fix(logs): support project name in positional argument #177

magurotuna merged 2 commits into from
Sep 12, 2023

Conversation

@magurotuna
Copy link
Member

@magurotuna magurotuna commented Aug 30, 2023

Fixes #176

@magurotuna magurotuna requested a review from satyarohith August 30, 2023 05:47
satyarohith
satyarohith approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magurotuna magurotuna merged commit 02c3c4b into denoland:main Sep 12, 2023
@magurotuna magurotuna deleted the logs-subcommand-support-project-name-in-positional-arg branch September 12, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satyarohith satyarohith satyarohith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

logs subcommand doesn't accept project name as a positional argument

2 participants

@magurotuna @satyarohith