-
Notifications
You must be signed in to change notification settings - Fork 65
Feat: deployctl deployments delete
#278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Yusuke Tanaka <[email protected]>
Co-authored-by: Yusuke Tanaka <[email protected]>
| Build | null | undefined, | ||
| Project | null | undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Build | null | undefined, | |
| Project | null | undefined, | |
| Build | undefined, | |
| Project | undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't do that, cause later we assign the result of api.getProject(): Project | null to this variable
satyarohith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from nit
resolves #232