Skip to content

Conversation

@arnauorriols
Copy link
Member

@arnauorriols arnauorriols commented Feb 26, 2024

resolves #232

Base automatically changed from deploymetns-list to main February 28, 2024 10:43
Comment on lines +226 to +227
Build | null | undefined,
Project | null | undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Build | null | undefined,
Project | null | undefined,
Build | undefined,
Project | undefined,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't do that, cause later we assign the result of api.getProject(): Project | null to this variable

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from nit

@arnauorriols arnauorriols merged commit 804d050 into main Feb 29, 2024
@arnauorriols arnauorriols deleted the deployments-delete branch February 29, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for deleting a deployment

3 participants