Skip to content

Bump npm version from 10.5.0 to 10.9.3 latest #12805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2025

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Aug 8, 2025

What are you trying to accomplish?

Updating npm version from 10.5.0 to 10.9.3 latest

Anything you want to highlight for special attention from reviewers?

By pre-installing [email protected] in the Docker build stage, we avoid corepack's automatic attempt to fetch and install the latest npm version when the updater runs.

How will you know you've accomplished your goal?

Previously, corepack would attempt to install npm@latest during updater execution, which could fail due to signature verification issues with private registries. This change ensures the desired npm version is already available in the container, eliminating that runtime dependency.

ex:
Ref: https://github.com/dsp-testing/npm-private-registry-10218-v1/actions/runs/16828342937/job/47669924247

2025/08/08 10:39:25 INFO <job_1071505941> Total execution time: 2.55 seconds
updater | 2025/08/08 10:39:25 ERROR <job_1071505941> Error installing npm@10: Adding [email protected] to the cache...
Internal Error: No compatible signature found in package metadata
    at verifySignature (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:21962:63)
    at installVersion (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22328:7)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Engine.ensurePackageManager (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22851:32)
    at async InstallGlobalCommand.installFromDescriptor (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:23267:5)
    at async Promise.all (index 0)
    at async InstallGlobalCommand.execute (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:23245:5)
    at async InstallGlobalCommand.validateAndExecute (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:20258:22)
    at async _Cli.run (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:21195:18)
    at async Object.runMain (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:23654:19)
updater | 2025/08/08 10:39:25 INFO <job_1071505941> Falling back to activate the currently installed version of npm.

After this:

updater | 2025/08/08 12:42:00 INFO Started process PID: 1257 with command: {} corepack npm -v {}
updater | 2025/08/08 12:42:01 INFO Process PID: 1257 completed with status: pid 1257 exit 0
updater | 2025/08/08 12:42:01 INFO Total execution time: 0.2 seconds
updater | 2025/08/08 12:42:01 INFO Installed version of npm: 10.9.3
updater | 2025/08/08 12:42:01 INFO Installed version for npm: 10.9.3
updater | 2025/08/08 12:42:01 INFO Processing engine constraints for npm
updater | 2025/08/08 12:42:01 INFO No version requirement found for npm
updater | 2025/08/08 12:42:01 INFO Running node command: node -v
updater | 2025/08/08 12:42:01 INFO Started process PID: 1269 with command: {} node -v {}
updater | 2025/08/08 12:42:01 INFO Process PID: 1269 completed with status: pid 1269 exit 0

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner August 8, 2025 12:51
randhircs
randhircs previously approved these changes Aug 8, 2025
Copy link
Contributor

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randhircs
Copy link
Contributor

@thavaahariharangit We may need to fix the required spec issue.

Revert NPM_VERSION to 10.5.0 for compatibility
Copy link
Contributor

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thavaahariharangit thavaahariharangit merged commit 30f8716 into main Aug 11, 2025
85 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/bump-npm-version-to-latest branch August 11, 2025 14:08
robaiken pushed a commit that referenced this pull request Aug 12, 2025
* Bump npm version from 10.5.0 to 10.9.3 latest

* Revert NPM_VERSION to 10.5.0

Revert NPM_VERSION to 10.5.0 for compatibility

* Update NPM_VERSION to 10.9.3

Updated NPM_VERSION to 10.9.3 in Dockerfile

* RSpec fixes

---------

Co-authored-by: kbukum1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants