-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bump npm version from 10.5.0 to 10.9.3 latest #12805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randhircs
previously approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thavaahariharangit We may need to fix the required spec issue. |
Revert NPM_VERSION to 10.5.0 for compatibility
Updated NPM_VERSION to 10.9.3 in Dockerfile
randhircs
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
1 task
robaiken
pushed a commit
that referenced
this pull request
Aug 12, 2025
* Bump npm version from 10.5.0 to 10.9.3 latest * Revert NPM_VERSION to 10.5.0 Revert NPM_VERSION to 10.5.0 for compatibility * Update NPM_VERSION to 10.9.3 Updated NPM_VERSION to 10.9.3 in Dockerfile * RSpec fixes --------- Co-authored-by: kbukum1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Updating npm version from 10.5.0 to 10.9.3 latest
Anything you want to highlight for special attention from reviewers?
By pre-installing
[email protected]
in the Docker build stage, we avoid corepack's automatic attempt to fetch and install the latestnpm
version when the updater runs.How will you know you've accomplished your goal?
Previously, corepack would attempt to install npm@latest during updater execution, which could fail due to signature verification issues with private registries. This change ensures the desired npm version is already available in the container, eliminating that runtime dependency.
ex:
Ref: https://github.com/dsp-testing/npm-private-registry-10218-v1/actions/runs/16828342937/job/47669924247
After this:
Checklist