[EasyCodingStandard] Parameters from base coding style ignored

[OndraM]

Hi, we are trying to update our base coding style to ECS 9, to use PHP config instead on YAML.

However I came across an issue with parameters being overwritten in the respective project which uses our base codestyle.

Base ecs.php:

return static function (ContainerConfigurator $containerConfigurator): void {
    $parameters->set(
        Option::SKIP,
        [
            'PHP_CodeSniffer\Standards\Generic\Sniffs\Commenting\DocCommentSniff.MissingShort' => null,
            // ...
        ]
}

ecs.php in project using the base coding style

return static function (ContainerConfigurator $containerConfigurator): void {
    $containerConfigurator->import(__DIR__. '/vendor/lmc/coding-standard/ecs.php');

    // Add some project-specific SKIPs
    $parameters = $containerConfigurator->parameters();
    $parameters->set(Option::SKIP, [__DIR__ . '/tests/PropertiesPrinterHelper.php']);
}

However, as a result, the Option::SKIP parameter from base coding style is overwritten, and MissingShort are not ignored.

Is there a way how to merge the parameters, as now they are probably overwritten? Am I missing something?

Thanks!

[OndraM]

I just discovered that if I put the import() statement at the end (ie. after the $parameters->set()), it starts to work.

Is this how the parameter merging is supposed to work?

[TomasVotruba]

Hi,

I think here we're limited by Symfony parameter mergin strategy. It works as expected - the last parameter wins.

Nette allows to choose merge strategy, see: https://doc.nette.org/en/3.1/di-services#toc-multiple-configuration-files
If Symfony would allow this, we can add it here too.

[OndraM]

@TomasVotruba So now the eg. SKIP parameter is not merged in any way? From the observed behavior it seems it actually is, but only in one order and not the other 🤔.

Is there any recommendation for this use case - importing base code style?

[TomasVotruba]

So now the eg. SKIP parameter is not merged in any way? From the observed behavior it seems it actually is, but only in one order and not the other thinking.

Looks like so :) it behaves the same way as Symfony.

Is there any recommendation for this use case - importing base code style?

Same as any imported Symfony config in parameters. Have saint defaults and override them only with intention. E.g. default Doctrine database connection will be overriden with prod/local configuration.

I personaly use SKIP parameter only the root ecs.php/rector.php.