스페이스 수정 버튼을 클릭했을 때, 토글 메뉴가 뒤늦게 사라지는 현상 수정 #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 데스크톱 모달 옵션 설정 시, 사이드 이펙트 수정
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
klmhyeonwoo
commented
Oct 12, 2025
|
|
||
| const close = useCallback(() => { | ||
| setModalDataState({ ...modalDataState, isOpen: false }); | ||
| setModalDataState({ |
Member
Author
There was a problem hiding this comment.
모바일의 경우에는 옵션을 넣는 경우가 많지 않아서 발견을 못한 것 같은데, 데스크탑 모달에서 옵션을 넣고 다른 데스크톱 모달을 열면서 옵션 값이 유지되는 현상을 발견했어요! 그래서 초기화해주는 부분을 넣었습니다! (모바일은 조금 더 확인해보겠습니다)
prgmr99
approved these changes
Oct 12, 2025
|
|
||
| const close = useCallback(() => { | ||
| setModalDataState({ ...modalDataState, isOpen: false }); | ||
| setModalDataState({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
close이벤트를 자동으로 붙이던 코드 제거 (사용자가 주입한onClose이벤트만 들어가도록 수정🧐 Issue number and link (참고)
📚 Reference (참조)