Handle Image Name/Tag parsing correctly with namespaced images #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more rubust solution that handles images with namespaces correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR switches image name/tag checks to use github.com/distribution/reference. This should be a more robust solution and handle edge cases better than the current strings.Split approach 😄.
Why
With the current implementation, Popeye flagged certain namespaced images as coming from a non-allowed registry, even when no registry was explicitly provided (which should default to docker.io). This led to false positives for me.
Notes
I’ve added tests that highlight the cases which were parsed incorrectly before, so it should be clearer what’s fixed now.
Thanks a lot for taking a look!
P.S. I reopened this PR because my initial tests were misleading — they were passing even without my changes. I realized the wrong method was being called in the test, so I’ve included that fix here as well 😅. Sorry for the extra notification spam!