Add option to ignore single line comments #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designfrontier
requested changes
Jul 10, 2019
| @@ -1,7 +1,7 @@ | |||
| const cp = require('child_process') | |||
| path = require('path'); | |||
|
|
|||
| module.exports = (details, publish) => { | |||
| module.exports.checkOwnership = (details, publish) => { | |||
There was a problem hiding this comment.
What is the reason for using a named export here instead of the default like it was using before? Doesn't seem to add any value?
There was a problem hiding this comment.
I don't know any other ways to make it mockable.
There was a problem hiding this comment.
did some digging and thinking and decided this will work
| }, {}); | ||
|
|
||
| Object.keys(emails).forEach((email) => { | ||
| // { size, ownedLines, author, file_path } | ||
| checkOwnership({ | ||
| size: lines, | ||
| utils.checkOwnership({ |
There was a problem hiding this comment.
same comment about the named export vs the default. Also utils implies that there are more utils in the module other than checkOwnership.
There was a problem hiding this comment.
utils is kinda just a random name, could be anything else really. The reason is the same as above.
designfrontier
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.