Add support for detecting push with secrets error #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new GitError type 'PushWithSecretDetected' and updated the GitErrorRegexes mapping to handle GitHub push protection errors. Added a test case to verify parsing of this specific error scenario.
sergiou87
approved these changes
Apr 21, 2025
Member
sergiou87
left a comment
sergiou87
left a comment
There was a problem hiding this comment.
Technically this is not a git error and therefore it should live in Desktop… not sure how much we should care about it if we eventually move this into the Desktop repo, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new GitError type 'PushWithSecretDetected' and updated the GitErrorRegexes mapping to handle GitHub push protection errors. Added a test case to verify parsing of this specific error scenario.