[desktop-lite] - Adding support for noVnc latest version in the feature #1395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1393
Description: This PR aims to solve #1393 by adding support for latest
noVnc
version. All thenoVnc
versions post1.2.0
are currently not working with thedesktop-lite
feature due to unavailability oflaunch.sh
script which is responsible for launching thenoVnc
client. In these higher versions ofnoVnc
client post1.2.0
, the client is required to be started usingnovnc_proxy
utility. Changes are done for adding that support & also ensured that support for the oldernoVnc
clients(<=1.2.0) remain as-is.Changlog: The following changes are done.
noVnc
client versions higher that1.2.0
devcontainer-feature.json
to do version bump & pining thenoVncVersion
property to the latest1.6.0
version.Checklist: