[dotnet] Follow symlinks during chown and add practical dotnet test
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
previously approved these changes
Nov 16, 2022
|
@joshspicer Are these changes still needed? If so, then can you help resolve the conflicts and I could help review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #293
Adds the
-Hflag when runningchownto follow symlinks.Additionally, adds a regression test validating the change fixes #293. The regression test will attempt to run a dotnet program, which includes a nuget dependency that needs to be resolved.
Takes advantage of:
remoteUsercli#286(⚠️ not yet released, test will fail until then)features test...command: Copy entire test folder on test execution and improve CLI command usage. cli#265