Skip to content

chore: Use Mapping instead of dict in types #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Use Mapping instead of dict in types #40

wants to merge 1 commit into from
+11 −4

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented May 28, 2025 •
edited
Loading

I figure it doesn't hurt to ensure we only use the mapping API. We only ever need read-only access anyways.

@kylebarron kylebarron changed the title chore: Using Mapping instead of dict in types chore: Use Mapping instead of dict in types May 28, 2025
@kylebarron
Copy link
Member Author

I don't think we can merge this (at least yet) because obstore requires literal dicts for now

@kylebarron kylebarron marked this pull request as draft May 28, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylebarron