Skip to content

Fix events description #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Fix events description #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98f84a
Fix description of events
sleshchenko Nov 9, 2020
5fc19ab
Regenerate CRDs and schemas
sleshchenko Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,8 +1584,8 @@ spec:
by its name.
properties:
postStart:
description: Names of commands that should be executed after
the workspace is completely started. In the case of Che-Theia,
description: IDs of commands that should be executed after the
workspace is completely started. In the case of Che-Theia,
these commands should be executed after all plugins and extensions
have started, including project cloning. This means that those
commands are not triggered until the user opens the IDE in
Expand All @@ -1594,21 +1594,21 @@ spec:
type: string
type: array
postStop:
description: Names of commands that should be executed after
stopping the workspace.
description: IDs of commands that should be executed after stopping
the workspace.
items:
type: string
type: array
preStart:
description: Names of commands that should be executed before
description: IDs of commands that should be executed before
the workspace start. Kubernetes-wise, these commands would
typically be executed in init containers of the workspace
POD.
items:
type: string
type: array
preStop:
description: Names of commands that should be executed before
description: IDs of commands that should be executed before
stopping the workspace.
items:
type: string
Expand Down
8 changes: 4 additions & 4 deletions crds/workspace.devfile.io_devworkspaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,7 @@ spec:
by its name.
properties:
postStart:
description: Names of commands that should be executed after
description: IDs of commands that should be executed after
the workspace is completely started. In the case of Che-Theia,
these commands should be executed after all plugins and
extensions have started, including project cloning. This
Expand All @@ -1623,21 +1623,21 @@ spec:
type: string
type: array
postStop:
description: Names of commands that should be executed after
description: IDs of commands that should be executed after
stopping the workspace.
items:
type: string
type: array
preStart:
description: Names of commands that should be executed before
description: IDs of commands that should be executed before
the workspace start. Kubernetes-wise, these commands would
typically be executed in init containers of the workspace
POD.
items:
type: string
type: array
preStop:
description: Names of commands that should be executed before
description: IDs of commands that should be executed before
stopping the workspace.
items:
type: string
Expand Down
16 changes: 8 additions & 8 deletions crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,29 +1516,29 @@ spec:
by its name.
properties:
postStart:
description: Names of commands that should be executed after the
workspace is completely started. In the case of Che-Theia, these
commands should be executed after all plugins and extensions have
started, including project cloning. This means that those commands
are not triggered until the user opens the IDE in his browser.
description: IDs of commands that should be executed after the workspace
is completely started. In the case of Che-Theia, these commands
should be executed after all plugins and extensions have started,
including project cloning. This means that those commands are
not triggered until the user opens the IDE in his browser.
items:
type: string
type: array
postStop:
description: Names of commands that should be executed after stopping
description: IDs of commands that should be executed after stopping
the workspace.
items:
type: string
type: array
preStart:
description: Names of commands that should be executed before the
description: IDs of commands that should be executed before the
workspace start. Kubernetes-wise, these commands would typically
be executed in init containers of the workspace POD.
items:
type: string
type: array
preStop:
description: Names of commands that should be executed before stopping
description: IDs of commands that should be executed before stopping
the workspace.
items:
type: string
Expand Down
12 changes: 6 additions & 6 deletions crds/workspace.devfile.io_devworkspacetemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,7 +1542,7 @@ spec:
by its name.
properties:
postStart:
description: Names of commands that should be executed after the
description: IDs of commands that should be executed after the
workspace is completely started. In the case of Che-Theia, these
commands should be executed after all plugins and extensions
have started, including project cloning. This means that those
Expand All @@ -1552,21 +1552,21 @@ spec:
type: string
type: array
postStop:
description: Names of commands that should be executed after stopping
description: IDs of commands that should be executed after stopping
the workspace.
items:
type: string
type: array
preStart:
description: Names of commands that should be executed before
the workspace start. Kubernetes-wise, these commands would typically
description: IDs of commands that should be executed before the
workspace start. Kubernetes-wise, these commands would typically
be executed in init containers of the workspace POD.
items:
type: string
type: array
preStop:
description: Names of commands that should be executed before
stopping the workspace.
description: IDs of commands that should be executed before stopping
the workspace.
items:
type: string
type: array
Expand Down
8 changes: 4 additions & 4 deletions pkg/apis/workspaces/v1alpha2/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@ type Events struct {
}

type WorkspaceEvents struct {
// Names of commands that should be executed before the workspace start.
// IDs of commands that should be executed before the workspace start.
// Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.
// +optional
PreStart []string `json:"preStart,omitempty"`

// Names of commands that should be executed after the workspace is completely started.
// IDs of commands that should be executed after the workspace is completely started.
// In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning.
// This means that those commands are not triggered until the user opens the IDE in his browser.
// +optional
PostStart []string `json:"postStart,omitempty"`

// +optional
// Names of commands that should be executed before stopping the workspace.
// IDs of commands that should be executed before stopping the workspace.
PreStop []string `json:"preStop,omitempty"`

// +optional
// Names of commands that should be executed after stopping the workspace.
// IDs of commands that should be executed after stopping the workspace.
PostStop []string `json:"postStop,omitempty"`
}
8 changes: 4 additions & 4 deletions schemas/latest/dev-workspace-template-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,28 +1508,28 @@
"type": "object",
"properties": {
"postStart": {
"description": "Names of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"description": "IDs of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"type": "array",
"items": {
"type": "string"
}
},
"postStop": {
"description": "Names of commands that should be executed after stopping the workspace.",
"description": "IDs of commands that should be executed after stopping the workspace.",
"type": "array",
"items": {
"type": "string"
}
},
"preStart": {
"description": "Names of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"description": "IDs of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"type": "array",
"items": {
"type": "string"
}
},
"preStop": {
"description": "Names of commands that should be executed before stopping the workspace.",
"description": "IDs of commands that should be executed before stopping the workspace.",
"type": "array",
"items": {
"type": "string"
Expand Down
8 changes: 4 additions & 4 deletions schemas/latest/dev-workspace-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,28 +1673,28 @@
"type": "object",
"properties": {
"postStart": {
"description": "Names of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"description": "IDs of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"type": "array",
"items": {
"type": "string"
}
},
"postStop": {
"description": "Names of commands that should be executed after stopping the workspace.",
"description": "IDs of commands that should be executed after stopping the workspace.",
"type": "array",
"items": {
"type": "string"
}
},
"preStart": {
"description": "Names of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"description": "IDs of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"type": "array",
"items": {
"type": "string"
}
},
"preStop": {
"description": "Names of commands that should be executed before stopping the workspace.",
"description": "IDs of commands that should be executed before stopping the workspace.",
"type": "array",
"items": {
"type": "string"
Expand Down
8 changes: 4 additions & 4 deletions schemas/latest/dev-workspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,28 +1686,28 @@
"type": "object",
"properties": {
"postStart": {
"description": "Names of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"description": "IDs of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"type": "array",
"items": {
"type": "string"
}
},
"postStop": {
"description": "Names of commands that should be executed after stopping the workspace.",
"description": "IDs of commands that should be executed after stopping the workspace.",
"type": "array",
"items": {
"type": "string"
}
},
"preStart": {
"description": "Names of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"description": "IDs of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"type": "array",
"items": {
"type": "string"
}
},
"preStop": {
"description": "Names of commands that should be executed before stopping the workspace.",
"description": "IDs of commands that should be executed before stopping the workspace.",
"type": "array",
"items": {
"type": "string"
Expand Down
8 changes: 4 additions & 4 deletions schemas/latest/devfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,28 +1426,28 @@
"type": "object",
"properties": {
"postStart": {
"description": "Names of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"description": "IDs of commands that should be executed after the workspace is completely started. In the case of Che-Theia, these commands should be executed after all plugins and extensions have started, including project cloning. This means that those commands are not triggered until the user opens the IDE in his browser.",
"type": "array",
"items": {
"type": "string"
}
},
"postStop": {
"description": "Names of commands that should be executed after stopping the workspace.",
"description": "IDs of commands that should be executed after stopping the workspace.",
"type": "array",
"items": {
"type": "string"
}
},
"preStart": {
"description": "Names of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"description": "IDs of commands that should be executed before the workspace start. Kubernetes-wise, these commands would typically be executed in init containers of the workspace POD.",
"type": "array",
"items": {
"type": "string"
}
},
"preStop": {
"description": "Names of commands that should be executed before stopping the workspace.",
"description": "IDs of commands that should be executed before stopping the workspace.",
"type": "array",
"items": {
"type": "string"
Expand Down
Loading