-
Notifications
You must be signed in to change notification settings - Fork 66
Add additional field to devworkspace status for showing info to users #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment on the issue: #220 (comment) about trying to be consistent with the corresponding fields in PodStatus
for example ?
5634d85
to
2fa57c5
Compare
@davidfestal Finally got around to updating this PR :) |
The conversion tests, as if to tell me they're actually useful, found a bug in conversion :). It is fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question left
The output for the current state of this PR is
Ideally we would be able to hide empty fields; I'm also considering moving INFO to be last in the list, but that may be confusing. Failed workspaces still do not put anything there, as the changes aren't implemented in the controller. |
cc: @davidfestal waiting on your re-review |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, davidfestal, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
683f4fb
to
9fdbb73
Compare
New changes are detected. LGTM label has been removed. |
What does this PR do?
Adds a field to the status subresource of DevWorkspaces which can be used to provide additional information about e.g. workspace failures and is printed in the short-form output of commands like
kuberctl get devworkspaces
What issues does this PR fix or reference?
Resolves #220, but should not be merged without discussion in the issue. I just wrote the PR since it's no effort to implement.
Is your PR tested? Consider putting some instruction how to test your changes
When applied to a cluster, output of
kubectl get devworkspaces
is something like(propagating failure reason to the status is not yet implemented on the controller side)