Skip to content

update boolean properties #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Aug 12, 2021

What does this PR do?:

Modifies the boolean properties so they are pointers to bool rather than the bool values itself in order to fix a parent override bug

Which issue(s) this PR fixes:

#545

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed
  • Unit/Functional tests

unit and functional tests were updated

N/A

  • Client Impact

Yes, clients were notified in bug issue above

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, kim-tsao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Sep 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2021

New changes are detected. LGTM label has been removed.

@kim-tsao kim-tsao merged commit da05a3e into devfile:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants