New Project/StarterProject Error Types #614
Conversation
kim-tsao
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
| @@ -111,6 +111,52 @@ func (e *InvalidComponentError) Error() string { | |||
| return fmt.Sprintf("the component %q is invalid - %s", e.componentName, e.reason) | |||
| } | |||
|
|
|||
| //MissingProjectRemoteError returns an error if the git remotes object under a project is empty | |||
| type MissingProjectRemoteError struct { | |||
There was a problem hiding this comment.
This file continue to grow more and more. Maybe it worths having a separate file for each type of error: commands, projects...
There was a problem hiding this comment.
I'll keep this under consideration the next time the file is changed. We will wind up with several files including a common one for an internal function under the same validation package but if we have that many error files, it might make more sense to refactor these into an error package and export that function.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, JPinkney, kim-tsao, sleshchenko, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Adds new error types for project and starter project validations
Which issue(s) this PR fixes:
#598
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
[ x] Unit/Functional tests
Local tests for now, as updates are being made in the library package. Verified the new types are being returned instead of strings:
QE Integration test
N/A
Documentation
N/A
N/A
How to test changes / Special notes to the reviewer: