Skip to content

Set v1alpha1 DevWorkspaces as served: false #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/typescript-model/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ WORK_DIR=${SCRIPT_DIR}/workdir
echo "[INFO] Using the following folder to store all build files ${SCRIPT_DIR}/workdir"
mkdir -p $WORK_DIR

GEN_REVISION=5c6d90b260fd94af32157f304f971778c899b5e2
GEN_REVISION=a3aef4de7a1d5dab72021aa282fffd8bc8a022ca

k8s_client_gen() {
[ ! -d $WORK_DIR/gen ] && git clone https://github.com/kubernetes-client/gen.git $WORK_DIR/gen || echo "kubernetes-client/gen is already cloned into $WORK_DIR/gen"
Expand Down
2 changes: 1 addition & 1 deletion crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4098,7 +4098,7 @@ spec:
- workspaceId
type: object
type: object
served: true
served: false
storage: false
- additionalPrinterColumns:
- JSONPath: .status.devworkspaceId
Expand Down
2 changes: 1 addition & 1 deletion crds/workspace.devfile.io_devworkspaces.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4094,7 +4094,7 @@ spec:
- workspaceId
type: object
type: object
served: true
served: false
storage: false
subresources:
status: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3891,7 +3891,7 @@ spec:
type: array
type: object
type: object
served: true
served: false
storage: false
- name: v1alpha2
schema:
Expand Down
2 changes: 1 addition & 1 deletion crds/workspace.devfile.io_devworkspacetemplates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3889,7 +3889,7 @@ spec:
type: array
type: object
type: object
served: true
served: false
storage: false
- name: v1alpha2
schema:
Expand Down
1 change: 1 addition & 0 deletions pkg/apis/workspaces/v1alpha1/devworkspace_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ const (
// +kubebuilder:printcolumn:name="Phase",type="string",JSONPath=".status.phase",description="The current workspace startup phase"
// +kubebuilder:printcolumn:name="URL",type="string",JSONPath=".status.ideUrl",description="Url endpoint for accessing workspace"
// +kubebuilder:deprecatedversion
// +kubebuilder:unservedversion
type DevWorkspace struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
// +k8s:openapi-gen=true
// +kubebuilder:resource:path=devworkspacetemplates,scope=Namespaced,shortName=dwt
// +kubebuilder:deprecatedversion
// +kubebuilder:unservedversion
type DevWorkspaceTemplate struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down