Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update to Operator SDK 1.1.
This process requires bootstrapping a new project using kubebuilder and porting files over to the new structure. See this repo for a more detailed commit history (though it's still a bit messy and hard to read). I generally tried to avoid making unnecessary changes, to make the transition easier, so the configmap is still used, webhooks are done as they are currently, etc.
Main directory structure changes:
deploy/ => config/
config/default
config/devel/
config/crds/
config/components/
and combinedconfig/registry
*_controller.go
filespkg/apis/ => apis/
apis/
are named after the resource's group (controller
in our case)pkg/controller/ => controllers
controllers
are named for the group of the CR they control (controller
forComponents
,WorkspaceRoutings
;workspace
forDevWorkspaces
)controllers/controller
subdirectory is further divided to distinguish between the controller for Components and WorkspaceRoutings.pkg
now contains mostly helper code frompkg
in the current repoOther notable differences
devfile/api
, I reworked the script to grab the files. It now downloads to a temp dir and copies definitions to the expected directory (config/crds
). The copied files are gitignored.Further TODOs
devfile/api
, reflected by changes here. This is set ingo.mod
as a replace.e2e
tests.What issues does this PR fix or reference?
Resolves #180
We'll likely need to do additional fixes to finalize this work
Is it tested? How?
Tested on minikube; still need to test WTO and
crc
use cases