Add CI check that generated files are up-to-date #246
Conversation
|
|
||
| # Note: fmt is necessary after generate since generated sources will | ||
| # fail format check by default. | ||
| make generate fmt manifests |
There was a problem hiding this comment.
it fails with Error patching crds: yq is required
There was a problem hiding this comment.
Ah bummer. That's probably why we didn't include it it in the first place.
There was a problem hiding this comment.
Added pip install yq and it seems to work without problems
Also add checking manifests to github PR CI Signed-off-by: Angel Misevski <[email protected]>
Fix issues resulting from Makefile semantics which result in statements being executed outside of the context of a rule: * Fix message logging that current-context is not set when there's no kubeconfig file (e.g. in CI). This checks if we're in minikube only. * Fix message warning that operator-sdk is not installed on every invocation; only print warning if a rule requires operator-sdk Signed-off-by: Angel Misevski <[email protected]>
|
Fixed CI (:tada:) and also improved Makefile slightly to not print warnings needlessly: were being printed because of how Make interprets lines not part of a rule. |
amisevsk
force-pushed
the
check-manifests-in-prcheck
branch
from
4fb7fa0 to
d92aa5e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I also added a commit (since dropped) that changed a manifest file to verify that CI will fail as we expect. |
|
/test v5-devworkspaces-operator-e2e |
What does this PR do?
Add a step to the GitHub CI jobs to check that
make generate manifestsdoes not change repo (ensure that generated yaml manifests and deepcopy functions are up to date).Update annotations on devworkspace reconciler to make sure we generate the RBAC we currently are using.
What issues does this PR fix or reference?
Running
make manifestschanges role.yamlIs it tested? How?