Skip to content

Update devfile api to include global attributes #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2021

Conversation

amisevsk
Copy link
Collaborator

What does this PR do?

Updates devfile/api dependency and CRDs to devfile/api@ff3c01b

This commit includes support for global attributes and variable replacement (though variable replacement is not yet implemented in the DevWorkspace Operator -- see #408)

What issues does this PR fix or reference?

Add support for top-level attributes in DevWorkspaces

Is it tested? How?

You can test the changes using the yaml

cat <<EOF | kubectl apply -f -
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: theia-next
spec:
  started: true
  template:
    attributes:
      test-2:
        this: is
        a: map
        of:
          free-form:
            attributes
    components:
      - name: theia
        plugin:
          uri: https://che-plugin-registry-main.surge.sh/v3/plugins/eclipse/che-theia/next/devfile.yaml
EOF

Update devfile/api dependency and CRDs to commit

ff3c01bf82927e2936d66f31b93e9463f9be25b3

to add support for global attributes and variable replacement

Signed-off-by: Angel Misevski <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Apr 30, 2021

@amisevsk: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-devworkspace-happy-path ac42a4b link /test v7-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, benoitf, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk amisevsk merged commit 92c0ced into devfile:main May 4, 2021
@amisevsk amisevsk deleted the update-devfile-api branch May 4, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants