Fix run/debug locally #486
Conversation
Fix make run and make debug by grabbing the tls certs used by the controller deployment and storing them in the expected path (k8s-webhook-server/serving-certs/) on the local machine. Since conversion webhooks are handled by the controller, they will not work when running/debugging locally. Signed-off-by: Angel Misevski <[email protected]>
|
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path |
|
@amisevsk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
PR #474 moved the conversion webhooks to the controller deployment, which requires the controller deployment to read mounted secrets to get the correct TLS cert.
For
make runandmake debugto work locally, we need to grab this secret and store its keys as files on the local disk as if it was a mounted secret (stored in/tmp/k8s-webhook-server/serving-certs/).Note that since conversion webhooks are now in the main deployment, conversion won't work when running locally.
What issues does this PR fix or reference?
Make run/debug broken
Is it tested? How?
make runmake debugPR Checklist
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-pathto trigger)v7-devworkspaces-operator-e2e: DevWorkspace e2e testv7-devworkspace-happy-path: DevWorkspace e2e test