fix: Update API's to work for OpenShift 4.9 #556
Conversation
extensions/v1beta1 Ingresses are deprecated as of k8s v1.14 and will be removed in v1.22 Signed-off-by: Angel Misevski <[email protected]> (cherry picked from commit 22891c4)
Required as v1beta1 webhooks will be unavailable soon. Also update webhooks configs to apply to v1 Ingresses on k8s (networking.k8s.io API group) Signed-off-by: Angel Misevski <[email protected]> (cherry picked from commit 39969c2)
Signed-off-by: Josh Pinkney <[email protected]>
Signed-off-by: Josh Pinkney <[email protected]>
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Josh Pinkney <[email protected]>
JPinkney
force-pushed
the
update-ingress
branch
from
8bf8b1a to
1d8e266
Compare
JPinkney
changed the title
sleshchenko
force-pushed
the
update-ingress
branch
from
9fa29c9 to
da3da5e
Compare
sleshchenko
changed the title
|
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path |
| APIGroups: []string{"controller.devfile.io"}, | ||
| APIVersions: []string{"v1alpha1"}, | ||
| Resources: []string{"devworkspaceroutings", "components"}, | ||
| }, | ||
| }, | ||
| }, | ||
| AdmissionReviewVersions: []string{"v1beta1", "v1"}, |
There was a problem hiding this comment.
why it's needed? when should we remove it?
There was a problem hiding this comment.
IIRC On OpenShift 4.9 it failed without it. I'll double check again though
There was a problem hiding this comment.
OK, seems I reproduced the issue you talk about on OpenShift 4.9
Error from server (InternalError): error when creating "./samples/flattened_theia-next.yaml": Internal error occurred: failed calling webhook "mutate.devworkspace-controller.svc": received invalid webhook response: expected response.uid="07b5b66c-0d84-48bb-939f-c4f6bdcaf3a5", got ""
I assume we should be able to remove it after we upgrade controller-runtime in Angel's PR.
|
@JPinkney: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
happy path test fails due #484 |
|
waiting for my OpenShift 4.8, 4.9 clusters to test these changes. |
sleshchenko
force-pushed
the
update-ingress
branch
from
da3da5e to
b039797
Compare
|
/test v7-devworkspaces-operator-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR builds off of #540 to make everything work for both OpenShift 4.8 and 4.9
What issues does this PR fix or reference?
Is it tested? How?
PR Checklist
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-pathto trigger)v7-devworkspaces-operator-e2e: DevWorkspace e2e testv7-devworkspace-happy-path: DevWorkspace e2e test