-
Notifications
You must be signed in to change notification settings - Fork 61
Propagate workspace .spec.started
to DevWorkspaceRouting
#604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add .spec.started field to DevWorkspaceRouting and propagate the value from DevWorkspace.spec.started to it. This ensures that a workspace's routing object will always queue at least one reconcile when it is started, and opens the option to clean up networking objects when a workspace is stopped in the future. Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
/test v8-devworkspace-operator-e2e, v8-che-happy-path |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Seems it's a breaking chang and DWCO fails to route routing https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/devfile_devworkspace-operator/604/pull-ci-devfile-devworkspace-operator-main-v8-che-happy-path/1440398068900958208/artifacts/che-happy-path/che-happy-path/artifacts/eclipse-che-info/che-operator-65c7f8454d-tw5fp-che-operator.log and screencast proves it, but happy test is too positive and happy with that ) Or it's just PR check. Will ask @musienko-maxim to discover the reason. And we probably should revert it and the only safest solution I see - use annotation instead.
|
Should fix the problem with always happy happy path test #609 |
What does this PR do?
Add field
.spec.started
to DevWorkspaceRouting and propagate the owning workspace's.spec.started
there. When a workspace is stopped, currently we simply end the routing reconcile early, but in the future this could be used to perform cleanup (e.g. remove services/routes for stopped workspaces).This change has the effect of always triggering at least one reconcile in the routing controller when a workspace is started.
What issues does this PR fix or reference?
Closes #602
Is it tested? How?
Start a workspace, stop a workspace.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che