Automatically migrate old configmap-based configuration to new CRD

[amisevsk]

What does this PR do?

Automatically converts configmaps from older versions of DWO to the new CRD. After migration is complete, the configmap is deleted from the cluster.

• Default values in the configmap are omitted (to avoid incidentally overriding new defaults in the CRD)
• If both a configmap and config CR exist:
  • If they are identical or if all custom values in the configmap are in the CR, migration proceeds (and deletes the configmap)
  • If they are differnent, an error is thrown.

What issues does this PR fix or reference?

Unfinished followup to #598

Is it tested? How?

Tests are included with PR (with decent coverage, at least). To test directly:

git checkout ec05d064 # Last pre-#598 commit
make uninstall docker install
kubectl get cm devworkspace-controller-configmap # Verify configmap exists
git checkout <pr-branch>
make docker install restart
kubectl get cm devworkspace-controller-configmap # Verify configmap is deleted

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[sleshchenko]

/test v8-devworkspace-operator-e2e, v8-che-happy-path

[sleshchenko]

I haven't tested but you add good unit tests, we should be safe.
Well done!

[sleshchenko]

Suggested change

	// convertConfigMapToConfigCRD converts a earlier devworkspace configuration configmap (if present)
	// convertConfigMapToConfigCRD converts an earlier devworkspace configuration configmap (if present)

ha!
🦅

[amisevsk]

😂

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, sleshchenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amisevsk,sleshchenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sleshchenko]

/test v8-devworkspace-operator-e2e

[openshift-ci]

New changes are detected. LGTM label has been removed.

[amisevsk]

/test v8-devworkspace-operator-e2e, v8-che-happy-path

[openshift-ci]

@amisevsk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v8-che-happy-path	49c21cc	link	true	/test v8-che-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.