Temporarily disable validation of DevWorkspaces to workaround api issue #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily disable validation of the flattened DevWorkspace to work around an issue in the devfile/api validation package where all endpoint targetPorts must be unique Signed-off-by: Angel Misevski <[email protected]>
ibuziuk
approved these changes
Apr 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Temporarily disable validation of the flattened DevWorkspace to work around an issue in the devfile/api validation package where all endpoint targetPorts must be unique.
This PR should be reverted once devfile/api#822 is merged and the updated dependency is pulled into the DWO repo.
This is also an opportunity to test #815 on the dogfooding instance if it is merged first :)
Validation generally does not catch many issues that are not caught by the schema, so including this change for now is low risk (worst case scenario is that the error message is perhaps less informative).
What issues does this PR fix or reference?
Workaround for #816
Is it tested? How?
Tested by starting
samples/theia-next.yamlDevWorkspacePR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che