-
Notifications
You must be signed in to change notification settings - Fork 27
Enable the devfile registry viewer #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the devfile registry viewer #73
Conversation
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
PRs to update the openshift template and operator (to be merged after this pr is merged): |
Signed-off-by: John Collier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GeekArthur, johnmcollier, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does does this PR do / why we need it:
This PR enables the devfile registry viewer in the devfile registry index server
/viewer
endpoint, we have to build the viewer withDEVFILE_VIEWER_ROOT=/viewer
/
:/index
if no content type requested/viewer
iftext/html
is requested (i.e. in a browser)/viewer
and/viewer/*
proxies all requests tolocalhost:3000/viewer
localhost:8080
/viewer
is liveWhich issue(s) this PR fixes:
Fixes devfile/api#534
PR acceptance criteria:
Test (WIP)
Documentation (WIP)