Skip to content

Enable the devfile registry viewer #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 17, 2021

Conversation

johnmcollier
Copy link
Member

@johnmcollier johnmcollier commented Jul 29, 2021

What does does this PR do / why we need it:
This PR enables the devfile registry viewer in the devfile registry index server

  • Updates the index server dockerfile to build the registry viewer
    • Base image changed to ubi8/nodejs-14-minimal
    • Since we're running the registry viewer under the /viewer endpoint, we have to build the viewer with DEVFILE_VIEWER_ROOT=/viewer
  • Index server entrypoint updated to start the node server for the registry viewer, in addition to the index server
  • Changes to index server endpoints:
    • /:
      • forwards to /index if no content type requested
      • forwards to/viewer if text/html is requested (i.e. in a browser)
    • /viewer and /viewer/* proxies all requests tolocalhost:3000/viewer
  • Helm chart updates:
  • Integration tests in progress

Which issue(s) this PR fixes:

Fixes devfile/api#534

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

@openshift-ci openshift-ci bot requested a review from elsony July 29, 2021 18:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@johnmcollier johnmcollier changed the title WIP: Enable the devfile registry viewer Enable the devfile registry viewer Aug 4, 2021
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
@johnmcollier
Copy link
Member Author

PRs to update the openshift template and operator (to be merged after this pr is merged):

Signed-off-by: John Collier <[email protected]>
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-08-06 at 12 34 47 PM

working as expected

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GeekArthur, johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GeekArthur,johnmcollier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier johnmcollier merged commit c6d49b7 into devfile:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard Registry Viewer to registry.devfile.io
3 participants