fix: stack Manager issues #6619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded installer module paths with configurable environment variables in `ServerEnvConfig`. This improves flexibility and maintainability, allowing paths to be customized without altering the codebase. Removed redundant constant `INSTALLER_MODULES_HELM_KEY`.
Updated functions to include `basePath` in module enable key generation, ensuring consistency and flexibility when constructing keys. Adjusted related calls across services to pass the `basePath` from environment configuration.
Revised the content of env_gen.json to modify the placeholder or default configuration. This ensures alignment with the expected environment setup and eliminates any outdated references.
Simplified and standardized the server status mapping by reinstating Helm release-based logic, removing redundant code, and eliminating the `mapApplicationStatusToServerStatus` function. This enhances maintainability and aligns with existing Helm release workflows.
Replaced incorrect usage of `sleep(180);` with `sleep 180` to align with proper syntax. This ensures the installation script runs without errors during execution.
Replaced incorrect usage of `sleep` with the proper function call `sleep(180)`. This ensures the script executes correctly without syntax errors.
Replaced the fixed sleep duration with repeated shellScript calls to improve the script's flexibility and manageability. This change aims to enhance the installation process by providing clearer execution control and better
Replaced the fixed sleep duration with repeated shellScript calls to improve the script's flexibility and manageability. This change aims to enhance the installation process by providing clearer
Shivam-nagar23
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
github-actions
bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
nishant-d
previously approved these changes
May 29, 2025
vikramdevtron
approved these changes
May 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2176
Checklist:
Does this PR introduce a user-facing change?